Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headline formatting cannot be removed in rare cases #883

Open
ironjan opened this issue Mar 1, 2021 · 2 comments
Open

Headline formatting cannot be removed in rare cases #883

ironjan opened this issue Mar 1, 2021 · 2 comments

Comments

@ironjan
Copy link

ironjan commented Mar 1, 2021

Steps to reproduce the behavior

In rare cases, formatting behaves weirdly and cannot be removed. It most often encountered this with headlines. I do not have reproduction steps for the issue, just a document that has the issue: https://www.notebook.ai/documents/125118

Removing the affected text and typing it new helps sometimes. However, in most cases, moving the text to an external plaintext editor, deleting the affected area (in this case the complete list and some text below), copying the text from the plaintext editor and formatting it from the beginning is the best bet.

Expected behavior

Headline formatting should not occur without being removable.

Actual behavior

In the following screenshot, the two last bullet points are to big:
headline_formatting

According to the formatting bar, they are formatted as H2. However, the list entries' text does not look like H2.
heading_2

When clicking H2 to remove the formatting, only the distance between the list items increases:
heading_3

When clicking "remove formatting" instead of H2, the formatting switches to actual H2 text style:
heading_4

@drusepth
Copy link
Member

drusepth commented Mar 4, 2021

Unfortunately, this is probably a bug in the rich text editor library we're using, which I've just realized is no longer maintained (oof).

I'll dig around their code and see if I can reproduce this and/or find a fix. In the meantime, the workaround you mentioned is indeed probably the best bet. Sorry about that.

@ironjan
Copy link
Author

ironjan commented Apr 5, 2021

I discovered another interesting issue related/caused by the rich text editor: formatting mixed type (headlines, no headlines) text can change the order of text. Hard to explain, so I just recorded a video: https://youtu.be/KYWiMy9Uhk4 (unlisted video).

The "Remove formatting" button does not work for mixed-type text which prompted me to try the "format everything as H1 and remove it again" workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants