Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: New release + publish from CI with a Trusted Publisher? #305

Open
woodruffw opened this issue Dec 11, 2023 · 9 comments
Open

Python: New release + publish from CI with a Trusted Publisher? #305

woodruffw opened this issue Dec 11, 2023 · 9 comments

Comments

@woodruffw
Copy link
Contributor

Now that #301 is merged, a new release is needed 🙂

On a tangential note: I don't see a current publishing workflow, which suggests that this package is currently being published from someone's development machine. My recommendation would be to switch to CI/CD for publishing, with a Trusted Publisher to do credentialless authentication to PyPI.

The PyPA has a guide for that here: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/

@woodruffw
Copy link
Contributor Author

(If there's interest, I can contribute that publishing workflow. But someone who currently controls the project on PyPI will need to do the configuration on that side.)

@joshuagl
Copy link
Contributor

cc @adityasaky

@adityasaky
Copy link
Member

(If there's interest, I can contribute that publishing workflow. But someone who currently controls the project on PyPI will need to do the configuration on that side.)

I currently control the PyPI project. Happy to help out with the config there, I've been meaning to enable this here and on in-toto but a PR would be great!

@woodruffw
Copy link
Contributor Author

Sounds good -- I'm going to wrap up #306 for tests and linting in CI and then I'll send a PR for the publishing workflow.

@lukpueh
Copy link
Member

lukpueh commented Dec 12, 2023

I've been meaning to enable this[...] on in-toto but a PR would be great!

Just did it for in-toto in-toto/in-toto#674 :)

@woodruffw
Copy link
Contributor Author

(In the mean time, I'd recommend doing one last manual release here -- #301 is currently blocking DSSE integration into sigstore-python.)

@adityasaky
Copy link
Member

@woodruffw #310

@marcelamelara
Copy link
Contributor

Looks like this issue was addressed, or is there a need for a more recent Python release?

@woodruffw
Copy link
Contributor Author

Looks like the release was handled, thanks!

The other part of the issue was Trusted Publishing, but that's tangential and could be tracked with a separate issue. I'll leave that up you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants