Skip to content

Commit

Permalink
Fixed some spotbugs warnings.
Browse files Browse the repository at this point in the history
  • Loading branch information
depryf committed Oct 26, 2023
1 parent b2b01e0 commit 74af98b
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 9 deletions.
24 changes: 20 additions & 4 deletions config/spotbugs/spotbugs-exclude.xml
Original file line number Diff line number Diff line change
@@ -1,20 +1,36 @@
<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter>
<!-- don't include auto-generated classes, not much we can do to fix those -->
<Match>
<!-- don't include auto-generated classes, not much we can do to fix those -->
<Class name="~.+Genedits(Regex)?(Lexer|Parser)"/>
</Match>
<!-- too many of these, and fixing them would be a huge undertaking, not worth the effort -->
<Match>
<!-- too many of these, and fixing them would be a huge undertaking, not worth the effort -->
<Bug code="EI,EI2"/>
</Match>
<!-- the translation itself uses questionable static variables, but changing that would be very difficult -->
<Match>
<!-- the translation itself uses questionable static variables, but changing that would be very difficult -->
<Bug code="MS"/>
</Match>
<!-- the MetafileUtils should be cleaned up at some point, for not I am ignoring it -->
<Match>
<!-- the MetafileUtils should be cleaned up at some point, for not I am ignoring it -->
<Class name="com.imsweb.validation.translation.metafile.MetafileUtils"/>
<Bug code="SQL"/>
</Match>
<Match>
<!-- Services/Engine allow to register a different instance; I don't know how to allow that without triggering this check -->
<Bug code="MS"/>
</Match>
<Match>
<!-- Do not reuse public identifiers from JSL as class name, fixing this is too disruptive -->
<Bug pattern="PI_DO_NOT_REUSE_PUBLIC_IDENTIFIERS_CLASS_NAMES"/>
</Match>
<Match>
<!-- Be wary of letting constructors throw exceptions, not easy to fix, and I don't think that can create a problem -->
<Bug pattern="CT_CONSTRUCTOR_THROW"/>
</Match>
<Match>
<!-- Field name shadows publicly available identifier from the Java Standard Library -->
<Bug code="PI"/>
</Match>
</FindBugsFilter>
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@

public class TranslationMapping {

public String _tag;
private String _tag;

public String _name;
private String _name;

public String _id;
private String _id;

public String _hash;
private String _hash;

public String _forcedTag;
private String _forcedTag;

public TranslationMapping() {
}
Expand Down

0 comments on commit 74af98b

Please sign in to comment.