Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition for TypeScript incorrectly augments "this" #174

Open
Burtsev-Alexey opened this issue Oct 23, 2024 · 3 comments
Open

Type definition for TypeScript incorrectly augments "this" #174

Burtsev-Alexey opened this issue Oct 23, 2024 · 3 comments

Comments

@Burtsev-Alexey
Copy link

Cleans up other projects augmentations as discussed in Vue official doc:

https://vuejs.org/guide/typescript/options-api.html#augmenting-custom-options

Breaks other projects, see:
primefaces/primevue#6624

This should be declare module ''vue' according to Vue doc (see first link)

declare module "@vue/runtime-core" {

@imcvampire
Copy link
Owner

imcvampire commented Oct 23, 2024

Thank you for the information. Will the change break be backward compatible with previous Vue version?

@Burtsev-Alexey
Copy link
Author

Thank you for the information. Will the change break be backward compatible with previous Vue version?

I don't know. I have started developing for Vue only a few weeks ago. I'm just learning

@imcvampire
Copy link
Owner

In this case, we can safely bump a major version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants