Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google-analytics processor #209

Open
ikalnytskyi opened this issue Nov 7, 2017 · 0 comments
Open

Add google-analytics processor #209

ikalnytskyi opened this issue Nov 7, 2017 · 0 comments
Milestone

Comments

@ikalnytskyi
Copy link
Owner

So far Holocron followed approach when Google Analytics counter was a part of theme templates, hence the theme was responsible for providing a way to propagate user's counter into HTML.

While this approach's good by its intention, it requires all the theme to implement the same thing. And if, by some reason, the theme doesn't implement we have no way to use Google Analytics.

So this ticket suggest to implement google-analytics processor that injects counter code into documents, providing a way not only to use GA counter with third-party theme but injecting counter into any HTML document.

@ikalnytskyi ikalnytskyi added this to the next milestone Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant