From 829a3c19c4450120a56b9b8392ef81efc8f89917 Mon Sep 17 00:00:00 2001
From: Guillaume Giudicelli <guillaume.giudicelli@inl.gov>
Date: Mon, 10 Jun 2024 12:12:03 -0700
Subject: [PATCH] Parameter adjustments for trapping physics

---
 src/physics/PointTrappingPhysics.C       | 6 +++---
 src/physics/SpeciesTrappingPhysicsBase.C | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/physics/PointTrappingPhysics.C b/src/physics/PointTrappingPhysics.C
index a1b53f9c..15e69449 100644
--- a/src/physics/PointTrappingPhysics.C
+++ b/src/physics/PointTrappingPhysics.C
@@ -26,7 +26,7 @@ registerMooseAction("TMAP8App", PointTrappingPhysics, "add_bc");
 InputParameters
 PointTrappingPhysics::validParams()
 {
-  InputParameters params = PhysicsBase::validParams();
+  InputParameters params = SpeciesTrappingPhysicsBase::validParams();
   params.addClassDescription("Add Physics for the trapping of species on enclosures / 0D components.");
 
   params.addRequiredParam<std::vector<std::vector<Real>>>(
@@ -69,7 +69,7 @@ PointTrappingPhysics::addComponent(const ComponentAction & component)
   checkComponentType<Enclosure0D>(component);
   const auto & comp = dynamic_cast<const Enclosure0D &>(component);
 
-  // This must be added
+  // Keep track of the names of the components
   _components.push_back(comp.name());
   if (isParamSetByUser("components"))
     paramError("components",
@@ -95,7 +95,7 @@ PointTrappingPhysics::addComponent(const ComponentAction & component)
                                                 true,
                                                 std::vector<Real>(0, n_species_component));
   processComponentParameters<MooseFunctorName>(
-      "temperatures", comp.name(), _component_temperatures, std::to_string(comp.temperature()), false, 0);
+      "temperatures", comp.name(), _component_temperatures, std::to_string(comp.temperature()), false, "0");
 
   // TODO: check that inputs are consistent once all components have been added.
   // - the pressure, temperature and the scaling factors should be positive (defense in depth from
diff --git a/src/physics/SpeciesTrappingPhysicsBase.C b/src/physics/SpeciesTrappingPhysicsBase.C
index 0302650c..4c24fd9e 100644
--- a/src/physics/SpeciesTrappingPhysicsBase.C
+++ b/src/physics/SpeciesTrappingPhysicsBase.C
@@ -41,7 +41,7 @@ SpeciesTrappingPhysicsBase::validParams()
       {},
       "Initial values for each species equation on each component. If a single vector is "
       "specified, the same initial conditions will be used on every component");
-  params.addParam<std::vector<MooseFunctorName>>("temperatures", "Temperatures for each enclosure component");
+  params.addParam<std::vector<MooseFunctorName>>("temperatures", {}, "Temperatures for each enclosure component");
   return params;
 }