Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add LOGOS from gitlab repo #2

Closed
wants to merge 1 commit into from
Closed

add LOGOS from gitlab repo #2

wants to merge 1 commit into from

Conversation

wangcj05
Copy link
Collaborator

Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

close #1
All tests are passing within RAVEN framework: idaholab/raven#1387
New regression test recipe will be add in the coming pull request. No test is needed for now.

What are the significant changes in functionality due to this change request?

Move the repo from GitLab to GitHub.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual.
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@wangcj05 wangcj05 requested a review from mandd January 12, 2021 17:50
wangcj05 added a commit that referenced this pull request Jan 12, 2021
@wangcj05
Merge branch 'update_ci' into 'master'
59f7667 
Update ci

Closes #2

See merge request RAVEN_PLUGINS/LOGOS!4
@wangcj05
Copy link
Collaborator Author

new PR with commit histories will be opened, , this one will be closed.

@wangcj05 wangcj05 closed this Jan 12, 2021
@wangcj05 wangcj05 deleted the wangc/init_logos branch January 12, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandd mandd Awaiting requested review from mandd

Assignees
No one assigned
Labels
priority normal task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move LOGOS from GitLab Repo to GitHub Repo
1 participant
@wangcj05