Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Capacity Factors should be between 0 and 1 #274

Open
10 tasks
GabrielSoto-INL opened this issue Mar 21, 2023 · 0 comments
Open
10 tasks

[TASK] Capacity Factors should be between 0 and 1 #274

GabrielSoto-INL opened this issue Mar 21, 2023 · 0 comments
Labels
priority-minor tasks or issues that are not time-sensitive or critical task Feature requests

Comments

@GabrielSoto-INL
Copy link
Collaborator


Issue Description

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
HERON should have an internal check to ensure that capacity factors are between [0, 1]. If not, should normalize.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@GabrielSoto-INL GabrielSoto-INL added task Feature requests priority-minor tasks or issues that are not time-sensitive or critical labels Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-minor tasks or issues that are not time-sensitive or critical task Feature requests
Projects
None yet
Development

No branches or pull requests

1 participant