Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple X-Correlation-IDs causing problem #268

Open
doertydoerk opened this issue May 31, 2022 · 1 comment
Open

Multiple X-Correlation-IDs causing problem #268

doertydoerk opened this issue May 31, 2022 · 1 comment
Assignees

Comments

@doertydoerk
Copy link
Contributor

In this line, an X-Correlation-ID is always added based on the SpanID. Not sure what we need this for, but it can cause problems in scenarios where an X-Correlation-ID is already set beforehand. For instance, tracing tools may get confused as to which ID to follow. That said, going from req.Header.Add() to req.Header.Set() won't fix the problem, as the existing ID would be overwritten and tracing would be corrupted.

IMHO, there should be only one X-Correlation-ID, so at least it should only be set if there isn't one already. Probably even better to not use X-Correlation-ID here and go with another header instead.

@Sharponentielle Sharponentielle self-assigned this Jun 7, 2022
@Sharponentielle
Copy link

The X-Correlation-ID is always added to outbound requests' headers. It propagates the trace ID.
What do you mean by tracing tool? Because this header is not set on requests that are sent to tracing tools like Jaeger or Zipkin.
I don't know what was the idea behind adding it since the opencensus library should already take care of this.

@bastianccm can provide us maybe with more information :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants