fix: add fallback to kurtosis terminal link #3227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can run into an issue where the URL to deploy to kurtosis does not display correctly for unsupported terminals. I have ran into this myself with my mac setup.
It manifests as:
Related issue: sindresorhus/terminal-link#18 (comment)
As suggested by a comment on the above issue, we can add a fallback to the
terminalLink
call to simply print the URL as a backup.