Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add fallback to kurtosis terminal link #3227

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

paulbalaji
Copy link
Contributor

Users can run into an issue where the URL to deploy to kurtosis does not display correctly for unsupported terminals. I have ran into this myself with my mac setup.

It manifests as:

  • "click here" text, no URL
  • unformatted text with URL containing "no-width space" characters

Related issue: sindresorhus/terminal-link#18 (comment)

As suggested by a comment on the above issue, we can add a fallback to the terminalLink call to simply print the URL as a backup.

Copy link

changeset-bot bot commented Feb 5, 2024

⚠️ No Changeset found

Latest commit: 2262f2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #3227 (aff803f) into main (8bfa8c1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3227   +/-   ##
=======================================
  Coverage   67.65%   67.65%           
=======================================
  Files          99       99           
  Lines        1014     1014           
  Branches      106      106           
=======================================
  Hits          686      686           
  Misses        284      284           
  Partials       44       44           
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 68.79% <ø> (ø)
isms 65.94% <ø> (ø)
token 58.41% <ø> (ø)
middlewares 81.46% <ø> (ø)

Copy link
Contributor

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@paulbalaji paulbalaji enabled auto-merge (squash) February 6, 2024 10:08
@paulbalaji paulbalaji merged commit fa058a0 into main Feb 6, 2024
12 of 13 checks passed
@paulbalaji paulbalaji deleted the fix/terminal-link branch February 6, 2024 10:50
ltyu pushed a commit to ltyu/hyperlane-monorepo that referenced this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants