-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging out on another domain doesn't log the user out #14
Comments
This should be fixable in 4.0 with session tokens, however we're kind of blocked on WP30247 to be able to share tokens across sites. |
@rmccue is this still an issue in 4.3.1? I tried testing this today with SSO enabled and it seemed to log me out everywhere. |
I'm 99% certain this still needs to be done; when we create the new cookie, we need to use the existing session ID. r32465 (since 4.3) should have made this possible, we just need to use it. |
I was having this issue, but I could not easily figure out how to actually fix it properly, even with the pointers above. For others that might have the same issue, here is my workaround. It destroys all the sessions the user that is logging out might have.
|
Fixes issue when logging out from the mapped domain. Fixes humanmade#14.
Just encountered this issue. bjork's solution destroys all user sessions, which is kind of a brute-force workaround. I've added a PR (#117), which does what rmccue states above: #14 (comment). If you're testing this PR, ensure you are logged out on the main site and on your mapped domain(s) beforehand. Then attempt to login on the main site. Next, open a new tab and navigate to the mapped domain. Lastly, attempt to logout from the mapped domain. |
We should instead log out of the main domain, then sync that back across.
The text was updated successfully, but these errors were encountered: