Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: BGene name and ID present, but name not showing for some entries in kidney v1.1 #396

Open
emquardokus opened this issue Apr 27, 2022 · 2 comments
Labels
bug Something isn't working HIGHEST PRIORITY

Comments

@emquardokus
Copy link
Collaborator

@vutukuriajay2241 @katyb @bherr2

I was trying to visualize the kidney v1.1 table and I saw a bunch of unnamed nodes for BGene so I investigated.

In the ASCT+B table, there is a name and ID for all the ones showing as unnamed nodes, they look the same as the ones for the named nodes.

I'm not sure I understand what the problem is?

When I look at the same table in the playground, it shows HGNC ID as the name, but in the actual table there is a name in the correct column
Screen Shot 2022-04-27 at 11 10 33 AM

This seems to be resolved in the revised kidney 1.2 draft table vis if you look at it in the playground: https://hubmapconsortium.github.io/ccf-asct-reporter/vis?selectedOrgans=example&playground=true

Screen Shot 2022-04-27 at 11 02 01 AM

Screen Shot 2022-04-27 at 11 02 48 AM

Screen Shot 2022-04-27 at 11 02 11 AM

@emquardokus emquardokus added bug Something isn't working HIGHEST PRIORITY labels Apr 27, 2022
@vutukuriajay2241
Copy link
Contributor

@emquardokus when I try to visualize Kidney 1.2 draft table https://docs.google.com/spreadsheets/d/1NMfu1bEGNFcTYTFT-jCao_lSbFD8n0ti630iIpRj-hw/edit#gid=949267305
It was able to visualize correctly in the Playground tool as well as the Organ selector table.

image

@emquardokus
Copy link
Collaborator Author

@vutukuriajay2241 I did say that this seemed to be corrected in v1.2draft table, but not sure what was wrong with v1.1 table since those rows were not substantially different. Trying to understand why since I'm also seeing this behavior for some other tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HIGHEST PRIORITY
Projects
None yet
Development

No branches or pull requests

2 participants