-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outdated README instructions for serving break new workbench template #24
Comments
Thanks for reporting this. Pull requests are welcome!
|
Hi Daniel - thank you for the suggestion. I created a pull request with a suggested change #26 -- someone will need to review and hopefully approve it. |
@DanilaFe Ok, I suggested the PR 26 to address this, and it did not pass the PR checks: "Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run" I don't know which file caused this error. I simplified this PR with a new PR 28 to replace it, and I get the same error. I modified only two files there: Makefile and README.md, so apparently I am not at liberty to edit those two files. Suggestions? |
Thank you @razoumov! I can't make sense of the error message either, unfortunately. It doesn't seem to me (scanning the CI configuration) that it makes use of the |
The Makefile is OK; this appears to have been an internal CI glitch. The checks do indeed pass. Closed by #28. |
Hello! I'm trying to suggest some changes to bring the Chapel code up to date w.r.t. the latest release, and ran into trouble getting started. All is well now, but I thought I'd mention it here, and provide the error message in case someone else runs into the same issue.
The
README.md
file for this repo currently instructs runningmake serve
to preview the lessons. This results in installing some Jekyll gems and generating a_site
folder in the repository. However, since this lesson has been updated to the new carpentry template in #23, the Jekyll build does not give a "proper-looking" website (themes are missing and some markdown content is not correctly rendered).Moreover, following the standard setup process for the carpentries workbench, running
sandpaper::build_lesson
in the folder causes the following error:Deleting the Jekyll-generated
_site
fixed this problem (andsandpaper::build_lesson
built everything just fine). However, perhaps the Makefiles and the README ought to be updated with the preview instructions?The text was updated successfully, but these errors were encountered: