-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Request: homebridge-tovala #753
Comments
🔴 The following checks failed:
🟢 The following checks passed:
If updating your |
what’s going on with all the spam (?) messages? |
/check |
🟢 The following checks passed:
🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team. |
Hi @kylewhirl I would like to suggest adding a
It is not normal (and not needed) to have these files/folders as part of the github repo. |
/check |
🟢 The following checks passed:
🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team. |
|
The only other thing I would suggest is slightly shorter logs on the event on an HTTP request failure. For example here I used invalid credentials to test the plugin, and is great that the plugin catches the error instead of crashing, but the resulting logs are:
|
Congratulations! Your plugin has been verified! You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel. Thank you for your contribution to the Homebridge community.
|
My two comments above are not part of the verification criteria so have verified the plugin 👍 |
Okay I’ll fix both of those, thank you! |
Also, the plugin icon is not showing in Homebridge but the plugin is shown is verified. Do I need to do anything to get it to show? |
It’s working now, thanks |
Plugin Name
homebridge-tovala
Link To GitHub Repo
https://github.com/kylewhirl/homebridge-tovala
Plugin Icon (Optional)
https://raw.githubusercontent.com/kylewhirl/homebridge-tovala/main/tovala-icon.png
The plugin does not offer the same nor less functionality than that of any existing verified plugin.
🟢 Yes
The plugin successfully installs and does not start unless it is configured.
🟢 Yes
The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
🟢 Yes
The plugin does not contain any analytics or calls that enable you to track the user.
🟢 Yes
If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.
🟢 Yes
The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.
🟢 Yes
More Information
No response
The text was updated successfully, but these errors were encountered: