-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Request: homebridge-kasa-python #746
Comments
🔴 The following pre-checks failed:
🟢 The following pre-checks passed:
If updating your |
I think your checks for verification need to be updated. I am using the latest template with engines defined as: Please advise. |
https://github.com/homebridge/verified/blob/latest/precheck/workspace/index.ts From line 163. I think it's like you say. Now it is that it must be compatible with homebridge 1.7.0 but it should be 1.8.0. Also node should be changed from 18.20.1 to 18.20.4 and from 20.12.0 to 20.16.0 . |
I think that it should also be updated to include node 22 and Homebridge 2.0 as well since those are now in the templates as well. |
This script checks whether your plugin supports the required versions. Node 22 is not required because the official version is from October 2024. I did PR with fixes for this. |
@mkz212 gotcha, thanks! |
/check |
🟢 The following checks passed:
🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team. |
@ZeliardM Congratulations on passing the exam 😀🎉 |
|
Congratulations! Your plugin has been verified! You can now add one of the Verified by Homebridge badges to your plugin's README:
Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions. If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along. Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel! As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel. Thank you for your contribution to the Homebridge community.
|
Plugin Name
homebridge-kasa-python
Link To GitHub Repo
https://github.com/ZeliardM/homebridge-kasa-python
Plugin Icon (Optional)
The plugin does not offer the same nor less functionality than that of any existing verified plugin.
🟠 No (please explain in the more information box at the end)
The plugin successfully installs and does not start unless it is configured.
🟢 Yes
The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
🟢 Yes
The plugin does not contain any analytics or calls that enable you to track the user.
🟢 Yes
If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.
🟢 Yes
The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.
🟢 Yes
More Information
There is an existing verified plug-in:
https://github.com/plasticrake/homebridge-tplink-smarthome
This plug-in has not been updated in 6 months and api have not been updated in 9 months. Several outstanding issues and user reported errors without fixes.
My plug-in uses a new python api that Home Assistant has just moved to for use and while I do not have the functionality of the api integrated yet, I am working on it.
I would also like to have a channel created on the discord server for user discussion if needed, I'm on discord a lot.
The text was updated successfully, but these errors were encountered: