-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start duckdb implementation of dremio #683
base: main
Are you sure you want to change the base?
Conversation
lumen/sources/dremio.py
Outdated
from pyarrow import flight | ||
|
||
|
||
class DremioClientAuthMiddleware(flight.ClientMiddleware): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure where I should put this; I pulled it from intake-dremio.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 57.03% 56.22% -0.81%
==========================================
Files 98 99 +1
Lines 11598 11804 +206
==========================================
+ Hits 6615 6637 +22
- Misses 4983 5167 +184 ☔ View full report in Codecov by Sentry. |
Started migrating stuff over to DuckDB source and will start testing.
Based off https://www.dremio.com/blog/using-duckdb-with-your-dremio-data-lakehouse/
So essentially, we still have to read the entire dataset and migrate it into a duckdb source. Previously with intake-dremio, I think we were doing dremio -> intake -> duckdb. now it's dremio -> duckdb
While doing that, would like your feedback on implementation or anything.
I think there are things we can tinker with for optimizing the reads like
read_chunk
and partitioning, etc