Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabulator row selection is incompatible with column filtering #138

Open
1 task
droumis opened this issue Sep 27, 2024 · 0 comments
Open
1 task

Tabulator row selection is incompatible with column filtering #138

droumis opened this issue Sep 27, 2024 · 0 comments

Comments

@droumis
Copy link
Member

droumis commented Sep 27, 2024

ALL software version info

(this library, plus any other relevant software, e.g. bokeh, python, notebook, OS, browser, etc should be added within the dropdown below.)

Software Version Info

Python              :  3.11.10 | packaged by conda-forge | (main, Sep 22 2024, 14:11:13) [Clang 17.0.6 ]
Operating system    :  macOS-13.5.2-arm64-arm-64bit
Panel comms         :  default

holoviews           :  1.19.1

bokeh               :  3.5.2
colorcet            :  3.1.0
cudf                :  -
cupy                :  -
dask                :  2024.9.0
dask-expr           :  1.1.14
datashader          :  0.16.3
geoviews            :  -
hvplot              :  0.10.0
ibis-framework      :  -
IPython             :  8.27.0
ipywidgets-bokeh    :  -
jupyter-bokeh       :  -
jupyterlab          :  4.2.5
matplotlib          :  3.9.2
networkx            :  -
notebook            :  6.5.7
numba               :  0.60.0
numpy               :  1.26.4
pandas              :  2.2.3
panel               :  1.5.0
param               :  2.1.1
pillow              :  10.4.0
plotly              :  -
pyarrow             :  17.0.0
pyviz-comms         :  3.0.3
scikit-image        :  -
scipy               :  1.14.1
spatialpandas       :  -
streamz             :  -
tsdownsample        :  0.1.3
xarray              :  2024.9.0

Description of expected behavior and the observed behavior

Applying a filter to a column breaks the proper selection link to associated annotation span.

Related to
holoviz/panel#3670
holoviz/panel#6997

Complete, minimal, self-contained example code that reproduces the issue

import pandas as pd
import hvplot.pandas
import holoviews as hv; hv.extension('bokeh')
import panel as pn; pn.extension('tabulator')

from holonote.annotate import Annotator
from holonote.app import PanelWidgets, AnnotatorTable
from holonote.annotate.connector import SQLiteDB

annotator = Annotator({'time': float}, fields=["description"],
                      connector=SQLiteDB(filename=':memory:'),
                      groupby = "description"
                     )
annotator.set_regions(time=(20,40))
annotator.add_annotation(description="A")

annotator.set_regions(time=(50,60))
annotator.add_annotation(description="B")

filters = {
    'description': {'type': 'list',
                    'func': 'in',
                    'valuesLookup': True,
                    'sort': 'asc',
                    'multiselect': True,
                    'placeholder': 'Filter Table'}
}
annotator_widgets = pn.WidgetBox(PanelWidgets(annotator),
                              AnnotatorTable(annotator,
                                             tabulator_kwargs=dict(
                                                 sizing_mode='stretch_both',
                                                 layout='fit_columns',
                                                 stylesheets=[":host .tabulator {font-size: 12px;}"],
                                                 header_filters=filters,
                                             )
                                            ),
                              max_width=350
                             )


n_samples = 100
data = np.random.randn(n_samples)

df = pd.DataFrame({'time': np.arange(len(data)), 'value': data})
plot = hv.Curve(df, ['time'], ['value']).opts(height=300)

pn.Row(annotator_widgets, annotator * plot)

Stack traceback and/or browser JavaScript console output

Screenshots or screencasts of the bug in action

GMT20240927-185838_Clip_Demetris.Roumis.s.Clip.09_27_2024.mp4
  • I may be interested in making a pull request to address this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant