Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version exclusion != not respected on Windows #90

Open
maximlt opened this issue Apr 1, 2022 · 5 comments
Open

Version exclusion != not respected on Windows #90

maximlt opened this issue Apr 1, 2022 · 5 comments
Labels
bug Something isn't working conda

Comments

@maximlt
Copy link
Contributor

maximlt commented Apr 1, 2022

Datashader's CI is failing on Windows. Its setup.py declares numpy >=1.7,!=1.22 and for some (still unknown, at least to me) reason the exclamation mark isn't passed down to conda which then translates it as numpy=1.22, exactly what we don't want!

See https://github.com/holoviz/datashader/runs/5788134696?check_suite_focus=true#step:8:149 where this commands:

conda install -y   "dask >=0.18.0" "datashape >=0.5.1" "numba >=0.51" "numpy >=1.7,!=1.22" "pandas >=0.24.1" "pillow >=3.1.1" "xarray >=0.9.6" "colorcet >=0.9.0" "param >=1.6.1" "pyct >=0.4.5" "scipy" "pytest >=3.9.3" "pytest-benchmark >=3.0.0" "pytest-cov" "codecov" "flake8" "nbconvert" "nbsmoke >0.5" "fastparquet >=0.1.6" "holoviews >=1.10.0" "bokeh" "pyarrow" "netcdf4" "twine" "rfc3986" "keyring" "spatialpandas" "rioxarray" "rasterio"

leads to:

    - numpy[version='>=1.7,=1.22']

In this PR #87 I tried to fix this issue by setting shell=False to CmdAction in a couple of occurrences, which failed miserably!

@hoxbro
Copy link
Contributor

hoxbro commented Apr 3, 2022

Could this be fixed by #73?

@maximlt
Copy link
Contributor Author

maximlt commented Apr 3, 2022

Oh well spotted! @philippjfr do you by any chance remember why you opened #73?

@philippjfr
Copy link
Contributor

Ha no, 2 years is a long time. Presumably for the same reason though.

@maximlt
Copy link
Contributor Author

maximlt commented Apr 3, 2022

Ok thanks anyway! Looks like a good candidate for fixing this issue, I'll have a go at it.

@maximlt
Copy link
Contributor Author

maximlt commented Apr 7, 2022

The root cause of this issue seems to be a conda bug (conda/conda#10522) by which a conda command executed on Windows with cmd.exe doesn't handle well characters like !. pyctdev uses doit which uses subprocess.Popen to run conda commands like conda install .... On Windows subprocess.Popen happens to run that command with cmd.exe when shell=True, which is the default of doit. Hence, the bug observed with pyctdev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda
Projects
None yet
Development

No branches or pull requests

3 participants