-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version exclusion != not respected on Windows #90
Comments
Could this be fixed by #73? |
Oh well spotted! @philippjfr do you by any chance remember why you opened #73? |
Ha no, 2 years is a long time. Presumably for the same reason though. |
Ok thanks anyway! Looks like a good candidate for fixing this issue, I'll have a go at it. |
The root cause of this issue seems to be a conda bug (conda/conda#10522) by which a conda command executed on Windows with |
Datashader's CI is failing on Windows. Its
setup.py
declaresnumpy >=1.7,!=1.22
and for some (still unknown, at least to me) reason the exclamation mark isn't passed down to conda which then translates it asnumpy=1.22
, exactly what we don't want!See https://github.com/holoviz/datashader/runs/5788134696?check_suite_focus=true#step:8:149 where this commands:
leads to:
In this PR #87 I tried to fix this issue by setting
shell=False
toCmdAction
in a couple of occurrences, which failed miserably!The text was updated successfully, but these errors were encountered: