Change HTTP method and enhance FHIR handling #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDeSain
commented
Nov 20, 2024
TDeSain
commented
- Update metadata endpoint to @PatchMapping
- Refactor models, add FhirControllerTest
- Improve FhirService, externalize API URLs
- Introduce FhirController with endpoints for metadata refresh and research studies retrieval - Implement FhirService for handling FHIR API interactions and dataset updates - Create model classes for FHIR resources: ResearchStudy, Bundle, Entry, Extension, Meta, and Link
- Change datasets metadata update method from GET to POST - Add abbreviation initialization in FhirService to prevent null errors - Remove redundant comments on getters and setters in Entry and ResearchStudy
- Externalized FHIR API base URL using @value annotation. - Utilized constant map for URL key mappings in metadata extraction. - Simplified method calls for accessing properties from ResearchStudy and Extension.
- Add FhirControllerTest for improved test coverage - Refactor models (Link, Meta, Entry, Extension, ResearchStudy, Bundle) to use Java records - Update FhirController endpoints to use ResponseEntity - Enhance FhirService with logging and cleaner dataset metadata updates - Add necessary dependencies to pom.xml for WebFlux and Actuator ```
- Replace @GetMapping with @PatchMapping for '/datasets/metadata/update' endpoint
- Change default value for missing researchStudy.title to an empty string - Ensure dataset fullName does not show "Missing researchStudy.title()" ```
- Refactor endpoint mappings in FhirController - `/datasets/metadata/update` to `/datasets/metadata/refresh` - `/research-studies` to `/research-studies/findAll` - `/distinct-phs-values` to `/listByDbgapAccessions` - Remove obsolete tests related to dataset metadata refresh - Update application properties with new FHIR configuration - Load URL to Key map dynamically from application properties - Ensure only existing datasets are updated in `updateDatasetMetadata`
- Modify FHIR controller endpoints for better organization - Add `spring.codec.max-in-memory-size` to dev properties - Update metrics tracking variables in FhirService - Enhance URL to Key Map initialization logic ```
- Modify FHIR controller endpoints for better organization - Add `spring.codec.max-in-memory-size` to dev properties - Update metrics tracking variables in FhirService - Enhance URL to Key Map initialization logic ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.