Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Particle strength exchange scheme gives wrong solutions #3

Open
hjabird opened this issue May 9, 2019 · 2 comments
Open

Particle strength exchange scheme gives wrong solutions #3

hjabird opened this issue May 9, 2019 · 2 comments
Assignees
@hjabird
Labels
bug Something isn't working

Comments

@hjabird
Copy link
Owner

hjabird commented May 9, 2019

There is less viscosity then there should be. Due to incorrectly ordered arguments in internally called functions.
@hjabird hjabird added the bug Something isn't working label May 9, 2019
@hjabird hjabird self-assigned this May 9, 2019
hjabird pushed a commit that referenced this issue May 12, 2019
GPU threshold (#4), Strength exchange bug (#3), Untracked bug.
dcf994d 
-Changed GPU usage threshold to 256 for all methods
-Fixed incorrect ordering of arguments in viscous vortex partice
strength exchange method. (The viscous code is still unverified)
-Fixed issue with CPU filament induced velocity implementation
where if a measurement point was on the axis of a vortex filament
a division by zero would suggest infinite induced velocity.
@hjabird
Copy link
Owner Author

hjabird commented May 12, 2019

Some work in commit dcf994d.
Argument ordering in internal calls swapped the viscosity and regularisation distance. This doesn't mean the code is actually correct however. Just less wrong.

hjabird pushed a commit that referenced this issue May 12, 2019
GPU threshold (#2), Strength exchange bug (#3), Untracked bug.
2e786fb 
-Changed GPU usage threshold to 256 for all methods
-Fixed incorrect ordering of arguments in viscous vortex partice
strength exchange method. (The viscous code is still unverified)
-Fixed issue with CPU filament induced velocity implementation
where if a measurement point was on the axis of a vortex filament
a division by zero would suggest infinite induced velocity.
@hjabird
Copy link
Owner Author

hjabird commented Aug 20, 2019

PSE seems to give correct solutions, only not a whole lot of viscosity transfer seems to happen. Perhaps this is to do with case setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjabird hjabird

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hjabird