Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cities are listed in states table for USA #32

Open
jawandsingh opened this issue Aug 21, 2017 · 6 comments
Open

cities are listed in states table for USA #32

jawandsingh opened this issue Aug 21, 2017 · 6 comments

Comments

@jawandsingh
Copy link

below are cities not states
(3923, 'Byram', 231),
(3925, 'Cokato', 231),
(3940, 'Lowa', 231),
(3944, 'Medfield', 231),
(3964, 'Ramey', 231),
(3968, 'Sublimity', 231),
(3971, 'Trimble', 231),

this one is a repeated state name with misspell
(3954, 'New Jersy', 231),
this is state of Canada
(3961, 'Ontario', 231),

@javydreamercsw
Copy link
Contributor

Any idea where those cities are from?

@javydreamercsw
Copy link
Contributor

Trying to fix this on PR #46

@jawandsingh
Copy link
Author

ok cool,

below are cities not states
(3923, 'Byram', 231),
(3925, 'Cokato', 231),
(3940, 'Lowa', 231),
(3944, 'Medfield', 231),
(3964, 'Ramey', 231),
(3968, 'Sublimity', 231),
(3971, 'Trimble', 231),

So, these records are listed in States.sql But these are actually cities. So, these must be in CIties.sql

P.S.:- I don't know which state these cities belong. As the data, I needed for my application was (Countries and States)

this one is a repeated state name with misspell
(3954, 'New Jersy', 231),

This record in States.sql is repeated one and it is misspelled.

this is state of Canada
(3961, 'Ontario', 231),

and this is actually a Canada State, Not USA State. So, This needs fix.

I hope this helps you to fix and merge in PR #46

@javydreamercsw
Copy link
Contributor

I fixed Ontario and New Jersey and deleted the other cities. Will be added when someone provides the right data.

@jawandsingh
Copy link
Author

well, I am closing this issue. Thanks for fixing it.

@javydreamercsw
Copy link
Contributor

Keep in mind those won't show up until the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants