Use xhp for html rendering #27

This library contain many non-final classes, all of which may have been extended elsewhere. Accept that this library doesn't meet this strict standard and move on.

This library contains classes with duplicate names. Example: ``` use type Facebook\Markdown\Block\ThematicBreak as ASTNode; class ThematicBreak {} ``` The alias to ASTNode allows the UnparsedBlocks\ThematicBreak to refer to the other. A use statement without an alias would create a name collision with the declaration. One could choose to always refer to the other node using a qualified name: Blocks\ThematicBreak

@ryangreenberg

This linter found `$offset;`, but I can't imagine what this was supposed to do. It's an int, so what the intent to increment / decrement it? Thank you @ryangreenberg for adding this linter to hhast.

https://codebeforethehorse.tumblr.com/post/87306947716/converting-a-project-to-xhp

XHP renders `disabled={true}` as `disabled`, but the spec expects `disabled=""`. It would be a shame if this small incompatibility would block xhp adoption. Let's make the spec tests allow these stringless boolean attributes.

The HTMLXHPRenderer still needs to be written.

All methods have been extracted from Renderer<T>. We need this interface to write tests again HTML(XHP)?Renderer. This itnerface allows us to reference them as `IRenderer<XHPChild>`.

Requires disabling child validation. Some of the specs expect invalid html.

One fewer "magic" type system lie! Explicitly use the `->forceAttribute()` api. This is the proper way to tell lies and will be caught when xhp attributes become sound.

We can't simply switch the HTMLRender to use HTMLXHPRenderer under the hood. The xhp renderer has slightly different output: - Boolean attributes are rendered as `attr` instead of `attr=""`. - Void elements don't include a trailing solidus (backslash) in their open tag. I'd not want to break test suites , bust caches, or break naive parsers. This change should be opt-in, but low friction.

HTMLXHPRenderer had a `$node !== ''` comparison. This is always false, but we don't case about the filter anyhow. Joining an empty string has the same effect as not joining it. Optimization also applied in HTMLRenderer.

Wrapping a vec of nodes in a frag is not needed if embedded in a node. The node would unpack the frag immediately and appended the children. This is what it does for a vec too.

The hhvm version is laughably out of date. We don't need hhvm-autoload, HH\Facts will do.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use xhp for html rendering #27

Use xhp for html rendering #27

Commits on May 27, 2023

Use xhp for html rendering #27

Are you sure you want to change the base?

Use xhp for html rendering #27

Commits on May 27, 2023