Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Support opacity for background tabs #7

Open
controversial opened this issue Feb 20, 2017 · 14 comments
Open

Support opacity for background tabs #7

controversial opened this issue Feb 20, 2017 · 14 comments

Comments

@controversial
Copy link

I'm using a hyper config where my window is transparent and vibrant:

screen shot 2017-02-20 at 12 29 04 pm

hyper-tabs-enhanced sets the background tab to opaque black, instead of a darker but still transparent look that I would expect. Perhaps for transparent black tabs, it should just increase background tab opacity?

@henrikruscon
Copy link
Owner

Can I get your config so I can try your setup? ✌️

@controversial
Copy link
Author

controversial commented Feb 20, 2017

sure :)

@henrikruscon
Copy link
Owner

henrikruscon commented Feb 20, 2017

skarmavbild 2017-02-20 kl 18 48 00

skarmavbild 2017-02-20 kl 18 49 34

It is transparent.

@controversial
Copy link
Author

Ah, so it is. I think it's darker than I'd like, though, could there be a config option for "degree of darkening?" Maybe I'll work on a PR?

@henrikruscon
Copy link
Owner

If there's a way to detect vibrancy and then based on that darken the color less, that would be ideal.

@controversial
Copy link
Author

https://github.com/matheuss/hyper-simple-vibrancy/blob/master/index.js#L1 sets the vibrancy inside the onwindow method, I'm not sure whether it's possible to access browserWindow outside of this.

@henrikruscon
Copy link
Owner

henrikruscon commented Feb 20, 2017

It is but I can't see that it holds the vibrancy variable. I'm gonna look into it more

@controversial
Copy link
Author

If there's a setVibrancy method I'd assume there was a corresponding getVibrancy method

@henrikruscon
Copy link
Owner

@controversial
Copy link
Author

Strange. Maybe a config option is the best way to go, then

@henrikruscon
Copy link
Owner

I've got a lot of work so I won't be able to look into this for like 3 days ✌️

@controversial
Copy link
Author

controversial commented Feb 21, 2017 via email

@outaTiME
Copy link

outaTiME commented Mar 13, 2017

Same when using hyper-transparent-dynamic

@jbergstroem
Copy link

Can confirm I get this as well. As much as I enjoy the unique features of this plugin I can't help but feel its too opinionated. It changes colors of my background, my inactive tabs and also interferes with icons. I guess its a combo plugin that sits well with the author and that's cool too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants