Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📌 Pull Request: Refactor & Enhance dbus-opendtu #227

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

📌 Pull Request: Refactor & Enhance dbus-opendtu #227

wants to merge 32 commits into from

Commits on Nov 11, 2024

  1. rename and refactor dbus-opendtu

    @0x7878
    0x7878 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5053731 View commit details
    Browse the repository at this point in the history

  2. add basic test wip

    @0x7878
    0x7878 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3f24b5e View commit details
    Browse the repository at this point in the history

  3. Refactor test_dbus-opendtu.py to remove unused mock_constants paramet… 

    …er in test_register_service method
    @0x7878
    0x7878 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d21f513 View commit details
    Browse the repository at this point in the history

  4. since paths is used as constant I moved it

    @0x7878
    0x7878 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    6c2c3a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Refactor imports in dbus_opendtu.py

    @0x7878
    0x7878 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    1e1190b View commit details
    Browse the repository at this point in the history

  2. Refactor test_dbus-opendtu.py to remove unused mock_constants paramet… 

    …er in test_register_service method
    @0x7878
    0x7878 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    9642657 View commit details
    Browse the repository at this point in the history

  3. Refactor code to remove unused paths

    @0x7878
    0x7878 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    52e3275 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Refactor code to remove unused paths parameter in DbusService constru… 

    …ctor
    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f531c41 View commit details
    Browse the repository at this point in the history

  2. Refactor test_dbus-opendtu.py to use register_services instead of reg… 

    …ister_service
    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5790d95 View commit details
    Browse the repository at this point in the history

  3. Refactor code to use register_services instead of register_service

    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    0e4e41d View commit details
    Browse the repository at this point in the history

  4. Refactor code to use get_DbusServices instead of register_services

    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    a8e3014 View commit details
    Browse the repository at this point in the history

  5. Refactor logging statement to use info level instead of critical

    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    bbf7e7d View commit details
    Browse the repository at this point in the history

  6. move code to add sign_of_life_all_services function and use it to sen… 

    …d a 'sign of life' signal to all services
    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d2ac513 View commit details
    Browse the repository at this point in the history

  7. Refactor file paths to use underscore instead of hyphen in dbus_opend… 

    …tu.py and restart.sh
    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f806c56 View commit details
    Browse the repository at this point in the history

  8. remove dependency and move code the main function (update routine)

    @0x7878
    0x7878 committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f7367b1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Add constants instead of hardcoded values

    @0x7878
    0x7878 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2bb1f02 View commit details
    Browse the repository at this point in the history

  2. move tests in proper folder

    @0x7878
    0x7878 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6a43f11 View commit details
    Browse the repository at this point in the history

  3. move functions to helpers instead of constants; add unit tests and im… 

    …prove function
    @0x7878
    0x7878 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1ca51d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Add coverage configuration and script 

    - Add .coveragerc file to control coverage.py and exclude certain directories from coverage analysis.
- Add run_coverage.sh script to run unit tests with coverage and generate coverage report.
    @0x7878
    0x7878 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    6370a8e View commit details
    Browse the repository at this point in the history

  2. Refactor code and improve error handling 

    Move functions to helpers instead of constants, add unit tests, and improve function to handle cases where there are no inverters or templates to query. Also, remove the dependency on running tests within the main function.
    @0x7878
    0x7878 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    3645b52 View commit details
    Browse the repository at this point in the history

  3. Add more tests

    @0x7878
    0x7878 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    a52c72d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. Completed Coverage for dbus_opendtu.py: 96%

    @0x7878
    0x7878 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    1807484 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:henne49/dbus-opendtu into feature-a… 

    …dd-test
    @0x7878
    0x7878 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    2294c0e View commit details
    Browse the repository at this point in the history

  3. Refactor _get_serial method in dbus_service.py

    @0x7878
    0x7878 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    9d4dc24 View commit details
    Browse the repository at this point in the history

  4. Refactor _get_name and _get_status_url methods in dbus_service.py

    @0x7878
    0x7878 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    ad73463 View commit details
    Browse the repository at this point in the history

  5. wip working fetch

    @0x7878
    0x7878 committed Nov 17, 2024
    Configuration menu
    Copy the full SHA
    25104b3 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Change number of Inverters in ahoy_0.5.93_live.json

    @0x7878
    0x7878 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    dc11282 View commit details
    Browse the repository at this point in the history

  2. Added template and inverter tests

    @0x7878
    0x7878 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    671e87f View commit details
    Browse the repository at this point in the history

  3. Move early fail condition to the right position

    @0x7878
    0x7878 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    dda5731 View commit details
    Browse the repository at this point in the history

  4. Refactored _read_config_dtu method and removed unreachable code 

    - Removed unreachable code in the _read_config_dtu method.
- Clarified the logic for reading the DTU variant and other configuration values.
- Ensured that the DTU variant is either constants.DTUVARIANT_OPENDTU or constants.DTUVARIANT_AHOY, raising an error otherwise.
- Improved readability and maintainability of the code.
    @0x7878
    0x7878 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ee69fd3 View commit details
    Browse the repository at this point in the history

  5. adjust tests

    @0x7878
    0x7878 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c6c094f View commit details
    Browse the repository at this point in the history

  6. Add test to verify that number_of_inverters are set 

    - Added a new test case to verify that the number of inverters is correctly set in the DbusService.
- Configured the test with a specific DTU variant and number of inverters.
- Used mocking to simulate the configuration and requests.
- Included assertions to validate the expected behavior.
    @0x7878
    0x7878 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    dff4727 View commit details
    Browse the repository at this point in the history