Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save screenshot not working for videos #22

Open
orvi opened this issue Jul 27, 2019 · 5 comments
Open

Save screenshot not working for videos #22

orvi opened this issue Jul 27, 2019 · 5 comments
Assignees
Labels

Comments

@orvi
Copy link

orvi commented Jul 27, 2019

How to reproduce

  1. Go the some page that contains posts with videos. for example: https://www.facebook.com/bbcnews/
  2. Find a post with a video and click save screenshot. Try for example this post

Actual Behavior

The little window is opened with the text Status: clicked 0 times, at least 0 more clicks... and nothing happen

Why it happens

The permalinks of videos are opened in Facebook Watch which have different layout then regular feed posts

How to fix

So I found out that if you add ?comment_id=1 to the post URL it will open it in the regular feed environment where the plugin can work.
For example:
https://www.facebook.com/bbcnews/posts/336144490663782?comment_id=1

Why I don't just push a PR

I don't have the setup to test addon and probably @hckr can fix it faster then me ;)

@hckr hckr self-assigned this Aug 2, 2019
@hckr hckr added the bug label Aug 2, 2019
@hckr
Copy link
Owner

hckr commented Aug 2, 2019

Hi @orvi,

Thanks for such an in-depth description and proposed solution. I'm on vacation now, that's why I haven't checked GitHub for some time. I'll fix this as soon as I have the opportunity (probably Monday or Tuesday).

@orvi
Copy link
Author

orvi commented Aug 2, 2019

No worries. Enjoy your vacation. Let me know if you have further questions :)

@hckr
Copy link
Owner

hckr commented Aug 5, 2019

I've updated the addon, it should be ok now.

@orvi
Copy link
Author

orvi commented Aug 6, 2019

Confirmed as fixed. Thanks.

@hckr
Copy link
Owner

hckr commented Jul 5, 2020

Unfortunately it's back to not working.

@hckr hckr reopened this Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants