-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic abbreviatedName property insted of specific ones #229
Comments
The property will be added to GND Ontology on 2022-02-08, from the announcement:
|
The property is now part of GNDO. Removing "upstream" tag and assigning @fsteeg to implement the change in the data. (We will probably have to discuss whether we should retain statements with specific properties to not break any applications.) |
I think we should add the generic property but retain the specific ones, which seem to be still used instead of the generic one, e.g. https://d-nb.info/gnd/600110-5/about/lds.rdf. Even if that changes with the next baseline dump, the specific properties are still in the ontology, so we should keep supporting them. Deployed to test, see https://test.lobid.org/gnd/context.jsonld (but no data yet). |
I don't agree. We don't support specific properties for |
Right, I think I get what you mean. If we'd do it like for But, as you wrote yourself above:
We basically can't be fully consistent if we don't want to introduce an API break here. And if we keep the old specific properties, we don't gain much by adding the generic one. We might consider the API break, but as hinted in #227, I think doing it the right, consistent way for all these Though it's probably not that much effort, if you feel that adding the generic property would be a big gain. |
As discussed offline, we aim at the consistent approach for all name properties, i.e. using |
First, the generic property has to be added to GNDO. From #228 (comment):
The text was updated successfully, but these errors were encountered: