Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic abbreviatedName property insted of specific ones #229

Open
acka47 opened this issue Sep 13, 2019 · 6 comments
Open

Use generic abbreviatedName property insted of specific ones #229

acka47 opened this issue Sep 13, 2019 · 6 comments

Comments

@acka47
Copy link
Contributor

acka47 commented Sep 13, 2019

First, the generic property has to be added to GNDO. From #228 (comment):

I opened an issue at https://jira.dnb.de/browse/GND-112 and will open another issue here for using the property instead of the specific properties as soon as it is added.

@acka47 acka47 added the upstream changes in upstream data/API needed label Sep 13, 2019
@acka47 acka47 self-assigned this Sep 13, 2019
@acka47
Copy link
Contributor Author

acka47 commented Nov 18, 2021

The property will be added to GND Ontology on 2022-02-08, from the announcement:

Neuerung: Die generische Property „gndo:abbreviatedName“ vom Typ
„owl:AnnotationProperty“ wurde eingerichtet.

@acka47
Copy link
Contributor Author

acka47 commented Aug 2, 2022

The property is now part of GNDO. Removing "upstream" tag and assigning @fsteeg to implement the change in the data. (We will probably have to discuss whether we should retain statements with specific properties to not break any applications.)

@acka47 acka47 removed the upstream changes in upstream data/API needed label Aug 2, 2022
@acka47 acka47 assigned fsteeg and unassigned acka47 Aug 2, 2022
@fsteeg
Copy link
Member

fsteeg commented Oct 7, 2022

Use generic abbreviatedName property insted of specific ones

I think we should add the generic property but retain the specific ones, which seem to be still used instead of the generic one, e.g. https://d-nb.info/gnd/600110-5/about/lds.rdf. Even if that changes with the next baseline dump, the specific properties are still in the ontology, so we should keep supporting them.

Deployed to test, see https://test.lobid.org/gnd/context.jsonld (but no data yet).

@acka47
Copy link
Contributor Author

acka47 commented Oct 10, 2022

Even if that changes with the next baseline dump, the specific properties are still in the ontology, so we should keep supporting them.

I don't agree. We don't support specific properties for preferredName, see #3 and should not do this for other name properties if we want to be consistent. As the needed information is given with type, the specific properties add redundancy which we do not need.

@fsteeg
Copy link
Member

fsteeg commented Oct 10, 2022

I don't agree. We don't support specific properties for preferredName, see #3 and should not do this for other name properties if we want to be consistent.

Right, I think I get what you mean. If we'd do it like for preferredName, we'd no longer have the specific fields in our data, and therefore wouldn't have to support them in the context or the reconciliation queries.

But, as you wrote yourself above:

(We will probably have to discuss whether we should retain statements with specific properties to not break any applications.)

We basically can't be fully consistent if we don't want to introduce an API break here. And if we keep the old specific properties, we don't gain much by adding the generic one.

We might consider the API break, but as hinted in #227, I think doing it the right, consistent way for all these *Name properties would be in the current DNB (or a new MARC-to-JSON) transformation. Implementing that first here, and then the clean way later seems like redundant work.

Though it's probably not that much effort, if you feel that adding the generic property would be a big gain.

@acka47
Copy link
Contributor Author

acka47 commented Oct 11, 2022

As discussed offline, we aim at the consistent approach for all name properties, i.e. using *Name only and getting rid of specific versions like *NameOfTheCorporateBody but will not implement this right now.

@acka47 acka47 removed their assignment Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants