Allow inner subqueries with CTEs in postgres #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tathougies
commented
Oct 18, 2024
| @@ -155,13 +155,13 @@ runPgRowReader conn rowIdx res fields (FromBackendRowM readRow) = | |||
| Pg.ConversionFailed { Pg.errSQLType = sql | |||
| , Pg.errHaskellType = hs | |||
| , Pg.errMessage = msg | |||
| , Pg.errSQLField = field } -> | |||
There was a problem hiding this comment.
Getting rid of GHC warnings here.
tathougies
commented
Oct 18, 2024
| in Q (liftF (QAll (\tblPfx tName -> | ||
| let (_, names) = mkFieldNames @Postgres @res (qualifiedField tName) | ||
| in fromTable (PgTableSourceSyntax $ | ||
| mconcat [ emit "(", fromPgSelect (fromSyntax tblPfx), emit ")" ]) |
There was a problem hiding this comment.
Need the ( ) to surround the WITH clause here.
tathougies
commented
Oct 18, 2024
|
|
||
| !beam-query | ||
| ```haskell | ||
| !example chinook only:Postgres |
There was a problem hiding this comment.
This actually works!
|
Tangential comment: what's the process for generating documentation now? |
|
I have a nix expression I use to build documentation. I know ken had some issues with using Nix, but my own workflow is nix heavy. I could try doing it with Docker and seeing if I get it to work. It unfortunately needs a postgresql server as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a response to #662 which allows postgres (which supports inner CTEs) to embed
Withmonads into regularQobjects, instead of justSqlSelect(which is whatselectWithdoes). TheselectWithbehavior is correct since that's the standard specified constraint, butpgSelectWithis more flexible.Docs are included (working on building them again)