Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Levant allocationStatusChecker do not consider should handle Nomad poststop tasks who are in pending states untill allocation is terminated #470

Open
scyd-cb opened this issue Nov 14, 2022 · 1 comment

Comments

@scyd-cb
Copy link

scyd-cb commented Nov 14, 2022

Description

when running levant deploy with a job defining a task with lifecycle posttop (to be run after the allocation is terminated for example to cleanup stuff), Nomad will show the task status as "pending " the nomad deployment is successful, however, levant allocation status checker will mark the deployment as incomplete and keep checking for the task to be running or complete https://github.com/hashicorp/levant/blob/main/levant/job_status_checker.go#L139.

Levant should make exception for posstop tasks as they should be completed only when the allocation is terminated.

Nomad: 1.4.2
Levant: 0.3.2

@linuxmail
Copy link

hi,

same for me. It's bad, because the Git pipeline will marked as fail, which is not true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants