Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype: VirtualMap to use Bytes instead of typed keys and values #16488

Closed
Tracked by #14395
artemananiev opened this issue Nov 7, 2024 · 2 comments · May be fixed by #16699
Closed
Tracked by #14395

Prototype: VirtualMap to use Bytes instead of typed keys and values #16488

artemananiev opened this issue Nov 7, 2024 · 2 comments · May be fixed by #16699
Assignees
@artemananiev
Labels
Performance Issues related to performance concerns. Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform

Comments

@artemananiev
Copy link
Member

This is a part of the Virtual Mega Map epic #14395.

To store entities of different types in a single virtual map, virtual maps should be changed to work with something more generic than strongly typed keys/values as today. Task #14802 is to have a design proposal how to do that. There are at least two approaches, but it isn't clear which one would be better and faster.

This ticket is to have a prototype for one of the approaches, which is to change all VirtualMap methods to work with PBJ Bytes. When the prototype is ready, it will be benchmarked heavily, and there will be more information to make a final decision.
@artemananiev artemananiev added Performance Issues related to performance concerns. Platform Virtual Map Platform Data Structures Platform Tickets pertaining to the platform labels Nov 7, 2024
@artemananiev artemananiev self-assigned this Nov 7, 2024
@poulok poulok mentioned this issue Nov 7, 2024
Open
@poulok poulok changed the title VirtualMap to use Bytes instead of typed keys and values Prototype: VirtualMap to use Bytes instead of typed keys and values Nov 7, 2024
This was referenced Nov 11, 2024
Open
Open
This was referenced Nov 21, 2024
Draft
Open
@artemananiev
Copy link
Member Author

The prototype shows about 15% regression in TPS in full-speed mode (NFT transfers benchmarks). This regression is caused by (de)serialization on the transaction handling thread, when objects are read from / put to virtual maps.

@artemananiev
Copy link
Member Author

I am closing this task as complete. The code is not merged anywhere, but the corresponding branch 16488-D-virtualmap-to-bytes is preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemananiev artemananiev

Labels
Performance Issues related to performance concerns. Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform
Projects
None yet
Milestone
No milestone
1 participant
@artemananiev