Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bingo Personal Stats Display #206

Open
hannibal002 opened this issue Jun 2, 2023 · 2 comments
Open

Bingo Personal Stats Display #206

hannibal002 opened this issue Jun 2, 2023 · 2 comments

Comments

@hannibal002
Copy link
Owner

hannibal002 commented Jun 2, 2023

Showing bingo related stats like playtime, death count or god splash time

sync up with /pt
handle god splash time gets cut in half after death, show a old -> new time message

@hannibal002 hannibal002 converted this from a draft issue Jun 2, 2023
@HacktheTime
Copy link

HacktheTime commented Dec 18, 2023

a) You no longer loose duration on death.
b) Legendary Bingo Pet can boost up to 50% extra Duration
c) Maybe read out got pot duration based on Duration on the Player with things like Strength 7 which are shown while in inventory. -> can be read out via the Minecraft.getMinecraft().thePlayer

Edit: While I have no idea how to integrate it properly in the Style this project is in, I have the potion reader:

Would break if you would disable strength for some reason, but that should never be a problem, since why would you ever do that. Strength 6 is maximum from Alixer with rank 4 so I think that should be safe. Strength is a vanilla effect and shown in the inventory and thereby can be tracked. at the same time, strength is an essential potion which is always a part in a god splash.

fun bingoGodPotionDuration(): Int {
        for (activePotionEffect in Minecraft.getMinecraft().thePlayer.activePotionEffects) {
            if (activePotionEffect.potionID.equals(Potion.damageBoost.id)) {
                if (activePotionEffect.amplifier >= 8) {
                    return activePotionEffect.duration
                }
            }
        }
        return 0;
    }

@RayDeeUx
Copy link
Contributor

a smidge of a caveat with your reply, @HacktheTime:

all development-related discussion happens on the skyhanni discord, typically within the #suggestions or #coding channels there. yes, the github issue we're typing our responses in very much exists, but it is mostly for hanni's self-documentation purposes.

anyways, looking forward to your response(s) there—especially for a function that doesn't know/clarify if it's returning the remaining duration duration in minecraft ticks, seconds, or minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants