-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to disable is_dangerous import checking #17
Comments
Hey @jfelten. Feel free to generate the PR! |
By the way, I didn't know people still used BrowserPilot. I haven't tested it for |
Thanks, @handrew. Yes, it seems to work well with gpt-4. This is good work, and I am surprised more people aren't using browserpilot. I will generate a Pull Request. |
I created #18. Unfortunately, I cannot get the example.py to run. Chrome webdriver crashes:
I noticed the same behavior on the main branch. I did verify that the published python package is working. It is using gpt-3.5-turbo not gpt-4 like I thought. Can you verify the code on main is correct and that my updating dependencies isn't breaking stuff? |
@jfelten It also did not work for me. I just pushed a fix for it. The problem was the |
Thanks! It works with gpt-4 now, but gpt-3.5-turbo now throws an error:
Might want to mention gpt-3.5-turbo in the docs is no longer supported, and/or throw an exception if it is specified. I will finish up testing my PR and mark it as ready to merge. |
Hmm @jfelten, now that I'm looking at your original issue, I think there might be a cleaner fix than disabling the danger check. Is it important for you to be able to import arbitrary libraries or code? Or do you just want to dump to JSON? If the latter, then I think a cleaner way to accomplish that is to simply add a new function call / capability to the prompt. |
I'd like the ability to disable the is dangerous check as needed through a flag:
browserpilot/browserpilot/agents/gpt_selenium_agent.py
Line 149 in b414a3c
My use case returns json, and generates an import statement that forces the code to exit:
If you are ok with this I can generate a PR.
The text was updated successfully, but these errors were encountered: