-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ManaToolkit as a new modules, and fixed ngrep. #37
base: master
Are you sure you want to change the base?
Conversation
… So, you guys decide if you want to have this into your list of modules
…it now downloads it from my repo. Latest version, compiled with correct version of libpcap
…ve mode of capturing NTLMv2 hashes via WPAD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work!
Responder can be updated but the module has to be updated in consequence (e.g. adding the --ProxyAuth option in the GUI, otherwise it's not usable). Did not know that ngrep was not in the officiel repo anymore. I'll have a look with @sebkinne with if it could be brought back as it would be more efficient to keep it in Hak5 official repo. Edit: I've sent a PR with adding the new version of Responder with the changes in the module itself. |
HI @adde88 thanks for making the PR! Could you please take out your ngrep fix for now? @WhistleMaster made some changes and I would like a PR for a new module to stand on it's own :) |
@sebkinne Would it be possible to bring back ngrep in the official repo ? |
@sebkinne |
@adde88 You should make the ngrep fix a different pull request on its own. |
Well, it should not in my opinion as the hak5 philosophy is to keep binary in the official repo, not in third party ones. And also, except the binary downloaded from another git, no changes were made in the ngrep module in it-self. |
The best option is definitely to keep the packages on the official Hak5 repos. When doing it like this there's a level of trust involved, as there's nothing stopping me (in theory) from adding malicious code to the binaries that are being launched on your Pineapples. |
I've added ManaToolkit as a module now. You guys decide if you want this to be an official module yet. It's working.
I've also added some changes to ngrep.
Ngrep isn't working because the package doesn't exist on the official openwrt repos.
So the changes i've made to the dependencies.sh script now downloads ngrep from my repo, which is the latest version compiled with the correct libpcap version. :)