From 08b31456713620d7277d941119ae64ae97b10a11 Mon Sep 17 00:00:00 2001
From: Robert Haase <haesleinhuepf@users.noreply.github.com>
Date: Thu, 10 Aug 2023 13:23:30 +0200
Subject: [PATCH] prevent re-running the last step by adding a summary step

closes #13
---
 demo/pandas_plotting.ipynb |  2 +-
 src/bia_bob/_machinery.py  | 23 ++++++++++++-----------
 2 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/demo/pandas_plotting.ipynb b/demo/pandas_plotting.ipynb
index 897c2e4..9e33f52 100644
--- a/demo/pandas_plotting.ipynb
+++ b/demo/pandas_plotting.ipynb
@@ -80,7 +80,7 @@
     {
      "data": {
       "text/markdown": [
-       "Here is the plot of x against y in the dataframe df."
+       "The plot shows the relationship between the variables x and y in the dataframe df."
       ],
       "text/plain": [
        "<IPython.core.display.Markdown object>"
diff --git a/src/bia_bob/_machinery.py b/src/bia_bob/_machinery.py
index 2b687e7..8516dfa 100644
--- a/src/bia_bob/_machinery.py
+++ b/src/bia_bob/_machinery.py
@@ -11,7 +11,7 @@ class _context():
 
 @register_line_cell_magic
 def bob(line: str = None, cell: str = None):
-    import re
+    from IPython.display import display, Markdown
     if _context.agent is None:
         init_assistant({})
 
@@ -23,19 +23,21 @@ def bob(line: str = None, cell: str = None):
         print("Variables:", len(_context.variables.keys()))
 
     if line and cell:
-        result = _context.agent.run(input=line + "\n" + cell)
+        prompt = line + "\n" + cell
     elif line:
-        result = _context.agent.run(input=line)
+        prompt = line
     elif cell:
-        result = _context.agent.run(input=cell)
+        prompt = cell
     else:
-        result = "Please enter a question behind %bob"
+        display("Please enter a question behind %bob")
+        return ""
 
-    # filter out markdown images from the response
-    pattern = r'!\[.*?\]\(.*?\)'
-    result = re.sub(pattern, '', result)
+    # why? https://github.com/haesleinhuepf/bia-bob/issues/13
+    if not prompt.strip().endswith("?"):
+        prompt = prompt + "\nSummarize the answers in maximum two sentences."
+
+    result = _context.agent.run(input=prompt)
 
-    from IPython.display import display, Markdown, Latex
     display(Markdown(result))
 
 
@@ -61,12 +63,11 @@ def init_assistant(variables, temperature=0):
     system_message = SystemMessage(content="""
     You never produce sample data.
     You never print out dataframes.
-    Do not answer questions that are not asked.
     Answer the human's questions below and keep your answers short.
     """)
     agent_kwargs = {
         "system_message": system_message,
-        "extra_prompt_messages": [MessagesPlaceholder(variable_name=MEMORY_KEY)],
+        "extra_prompt_messages": [MessagesPlaceholder(variable_name=MEMORY_KEY)]
     }
     _context.agent = initialize_agent(
         _context.tools,