added a fix for Home Assistant 2024.1.0 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you very much for you contribution! |
|
@h4de5 Can this be published? |
|
donev 86f9dba sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the calls to
ToshibaAcEnumSelectDescription.__init__()in_SELECT_DESCRIPTIONSwas missing anicon_mappingparameter which started causing issues on Home Assistant 2024.1.0. I've added the missing parameter which has fixed the issue. Another option would have been to mark the field as optional but this was a simpler change (I'm not an experienced Python dev, most of my work is in TypeScript).I've tested this change on my local instance and it fixes the issue.