Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional MINOS status codes #465

Open
jedori0228 opened this issue Mar 27, 2024 · 2 comments
Open

Additional MINOS status codes #465

jedori0228 opened this issue Mar 27, 2024 · 2 comments

Comments

@jedori0228
Copy link

jedori0228 commented Mar 27, 2024

I found some cases where the MinosStatus() is 8 or 16, and currently it causes error at

LogWarning << GundamUtils::minosStatusCodeStr.at(_rootMinimizer_->MinosStatus()) << std::endl;

as these are not defined at
static const std::map<int, std::string> minosStatusCodeStr{
{ 0, "status = 0 : last MINOS run was succesfull" },
{ 1, "status = 1 : Maximum number of function calls exceeded when running for lower error"},
{ 2, "status = 2 : maximum number of function calls exceeded when running for upper error"},
{ 3, "status = 3 : new minimum found when running for lower error"},
{ 4, "status = 4 : new minimum found when running for upper error"},
{ 5, "status = 5 : any other failure"},
{ -1, "status = -1 : Minos is not run"}
};

@nadrino
Copy link
Collaborator

nadrino commented Mar 27, 2024

Thank you very much for this issue!

Indeed, those status dictionary are quite outdated now and the use std::map is not very well suited to handle the messaging. I'll have a look in the near future.

@ClarkMcGrew
Copy link
Contributor

Need to fix code so unknown errors have reasonable behavior. The line at RootMinimizer 299 is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants