Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the core::matches macro for enum variant equality checks #127

Open
2 tasks
PopcornPaws opened this issue Mar 28, 2023 · 0 comments
Open
2 tasks

Use the core::matches macro for enum variant equality checks #127

PopcornPaws opened this issue Mar 28, 2023 · 0 comments
Assignees
@PopcornPaws
Labels
f1-improvement enhancing existing functionality

Comments

@PopcornPaws
Copy link
Contributor

Description

Instead of using our matches_variant implementation from gn-common/utils.rs, we should use the built-in function for that.

Solution

  • remove matches_variant from gn-common/utils.rs
  • replace matches_variant with core::matches!(...) wherever needed (oracle + wasm code)
@PopcornPaws PopcornPaws self-assigned this Mar 28, 2023
@PopcornPaws PopcornPaws added f1-improvement enhancing existing functionality and removed enhancement labels Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PopcornPaws PopcornPaws

Labels
f1-improvement enhancing existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PopcornPaws