Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did you set $condition_vec=128$ not the simplest $condition_vec=4$ ? #12

Open
hihunjin opened this issue Oct 12, 2021 · 2 comments
Open

Comments

@hihunjin
Copy link

hihunjin commented Oct 12, 2021

I read your paper and in the code, you set c.condition_vec = 128.
And the positionendoding2d function consists of dimension DxHxW.
It seems the 4 channels are duplicated in the last 124 channels. Why did you keep the channel 128? Could it just be 4?

@gudovskiy
Copy link
Owner

@hihunjin I didn't check, but channels shouldn't be duplicated. Did you verify duplication?

@hihunjin
Copy link
Author

@hihunjin I didn't check, but channels shouldn't be duplicated. Did you verify duplication?

Cuz your 128 is not duplicated, your first 4 channel must not be duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants