Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manuscript revisions meta issue #151

Closed
33 tasks done
agitter opened this issue Feb 8, 2019 · 13 comments
Closed
33 tasks done

Manuscript revisions meta issue #151

agitter opened this issue Feb 8, 2019 · 13 comments

Comments

@agitter
Copy link
Collaborator

agitter commented Feb 8, 2019

We received positive reviews on our manuscript and can use this issue to organize the revisions over the next few weeks. Let's target resubmitting the week of March 4 or earlier.

All of the requested revisions are itemized below. Following @dhimmel's suggestion, the first one to start a pull request to address a comment can claim it. If there is something you know how to address, you can also assign yourself to the issue before making the pull request. We may need to discuss some of these in the issue before we know edits to make.

We'll keep the pull requests small so they can be merged quickly, though I suggest leaving them open at least 12-24 hours so we can all monitor changes.

In addition to editing the manuscript, we now have a response-to-reviewers.md. Initially this document only has the quoted reviewer comments. When you update the manuscript, please also add a summary of your changes to this point-by-point response letter. See the examples in deep-review and scihub.

Reviewer 1

Reviewer 2

Reviewer 3

Additional revisions

cc @dhimmel @slochower @vsmalladi @vincerubinetti @dongbohu @cgreene

@agitter
Copy link
Collaborator Author

agitter commented Feb 21, 2019

PLOS sent me a reminder that they would like the revision by March 7. I can easily request an extension but would like to discuss our timeline for the revisions. I should have more time to work on this over the next few weeks.

Can we start by going through the issues and making sure one or more of us has self-assigned to each one?

@slochower
Copy link
Collaborator

I'm going through a busy period at work, so I will be most effective if I can narrow my attention to a few Issues/PRs.

I can add a little more text to #146.
#143 seems like low hanging fruit.
#142 seems like it's open ended. Probably need to narrow focus a bit -- presumably some journals no problem with format, some journals will not be happy.
#141 I can put the Pros/Cons in the text, but @dhimmel knows more about JATS and could fill in some other advantages.
#139 I could redo the mini-movie with some guidance from @agitter and @dhimmel on what they'd like to see.
#131 I can briefly mention these in a PR to the introduction.
#130 needs some thought.

@agitter
Copy link
Collaborator Author

agitter commented Feb 22, 2019

Thanks @slochower, I'll look through some of the other issues you didn't mention and try to focus on those. I'm fairly busy over the next week but may free up somewhat after that.

@vsmalladi
Copy link
Collaborator

I’m also just getting back from traveling so will take a look at other issue this week.

@agitter
Copy link
Collaborator Author

agitter commented Feb 26, 2019

I requested more time for the revisions without specifying a specific new deadline. I'm going to actively dig into the revisions Friday or Saturday and expect to make substantial progress the following week.

Can anyone help update Table 1 for #146 and #147? We should make sure this table is still accurate with respect to the most recent versions of platforms like Overleaf that have changed a lot.

@agitter
Copy link
Collaborator Author

agitter commented Mar 22, 2019

@dhimmel @slochower @vsmalladi @cgreene how feasible would it be for us to finish the meta review revisions in the next 7-10 days? We made good progress over the past week. I'd like to agree on a deadline so that we can wrap this up.

I'm going to go through the open issues and work on identifying a lead for each one. That can help scope how much more time we need.

@slochower
Copy link
Collaborator

I think it's feasible. On a personal note, I will be traveling and giving two talks next week so I'm not entirely clear what my availability will be. If you can assign me Issues before this Sunday, I think I can more easily weave them into my downtime.

@dhimmel
Copy link
Contributor

dhimmel commented Mar 27, 2019

how feasible would it be for us to finish the meta review revisions in the next 7-10 days?

I think wrapping things up in the next week is reasonable, and I'll aim for that. @agitter, I think you probably have the best handle on what's left to do. Feel free to assign me issues that you think I'll be the most effective in addressing.

@dhimmel dhimmel pinned this issue Mar 28, 2019
@agitter
Copy link
Collaborator Author

agitter commented Apr 4, 2019

We're getting very close now. We have pull requests open for most of the remaining issues, and the others are small in scope. I may try to finish the edits in the next couple days so that we can do a final review and resubmit April 7 or 8.

If anyone wants more time to review the new version, please let me know.

@agitter
Copy link
Collaborator Author

agitter commented Apr 4, 2019

The journal emailed me again asking whether or not we plan to resubmit. I'll tell them that we do plan to resubmit and it will be next week. I'm targeting very early next week.

@agitter
Copy link
Collaborator Author

agitter commented Apr 12, 2019

🎉 The resubmission is in! 🎉

I'm leaving this open as a reminder that we need to update the binder tag and create the v3.0 tag and release.

@slochower
Copy link
Collaborator

Thank you & everyone else for the hard work!

@agitter agitter unpinned this issue Apr 13, 2019
@agitter
Copy link
Collaborator Author

agitter commented Apr 13, 2019

I updated the tags and am closing this issue. The binder tag was originally 313023e and is now 4ef4d9f. That is the same commit as the v3.0 release.

@dhimmel you can update the release notes if you'd like. One consideration is whether we want to explain in the release notes why the tagged commit is one ahead of the commit we used for the diff.

@agitter agitter closed this as completed Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants