-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regarding the names of name origin groups, what do you think about these new names: #94
Comments
So are we still grouping Greek with European even though Greek is its own top-level nameprism group? |
I still think lettered groupings are a better way to go. When you consider how far removed we are from the actual naming history of each of the names that comprise the training set, it's hard to say we've actually made categories according to this taxonomy. I feel less strongly about that than I feel about using the top level nameprism group, which I do think we should do. If we don't have enough training examples for robust performance on some we will have to just drop the categories. |
My bad. I meant to add Greek names there. Edited. |
Performance seems robust. Prediction of African names has the lowest auROC (92.2%) likely because there are fewer Wikipedia entries.
I understand why we would want to go with lettered groupings. However, with 10 categories, I think it's very challenging to map the letters/colors to the region. We did our best in terms of removing the mix of religions/country/area in the NamePrism group names and focus on the language. We will certainly point out the potential mismatch (e.g., as Iddo pointed out in #27, name of a person from Israel can be of Hebrew, Arabic or European origin - which is reflected in the heatmap), but I do think the group names helped the reader see how we made our predictions. |
I am willing to defer to your judgement as first author. Thanks for considering it carefully! |
Regarding the names of name origin groups, what do you think about these new names:
@cgreene @dhimmel @arielah
Originally posted by @trang1618 in #56 (comment)
The text was updated successfully, but these errors were encountered: