Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "facebook" namespace from cpp? #94

Open
leebyron opened this issue Nov 7, 2019 · 1 comment
Open

Remove "facebook" namespace from cpp? #94

leebyron opened this issue Nov 7, 2019 · 1 comment

Comments

@leebyron
Copy link
Contributor

leebyron commented Nov 7, 2019

Since this project has moved from Facebook to the foundation, does it make sense to remove the namespace from the cpp files? This would be considered a breaking change. Open to discussion.

@ErikWittern
Copy link
Contributor

I think this is the right move in the long run, but needs to be accompanied by a corresponding change in version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants