Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend schema to allow for presigned URLs for uploading files #108

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Extend schema to allow for presigned URLs for uploading files #108

wants to merge 13 commits into from

Conversation

singingwolfboy
Copy link
Collaborator

@singingwolfboy singingwolfboy commented Feb 12, 2020 •
edited
Loading

Follow-up to #107. This extends our GraphQL schema to expose a createUploadUrl mutation, which allows an API client to get a pre-signed URL for uploading a file to S3.

@singingwolfboy singingwolfboy mentioned this pull request Feb 13, 2020
Open
benjie
benjie requested changes Feb 24, 2020
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, sorry about the delay - I've been busy on other projects.

@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Show resolved Hide resolved
@benjie
Copy link
Member

benjie commented Apr 20, 2020

CI is failing because aws-sdk was not added as a dependency of the relevant package.

benjie
benjie requested changes Apr 20, 2020
View reviewed changes
Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this PR 👍 I've left some more feedback.

@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
@app/server/src/plugins/CreateUploadUrlPlugin.ts Outdated Show resolved Hide resolved
This was referenced May 15, 2020
Closed
Draft
@benjie
Copy link
Member

benjie commented May 15, 2020

I tried to get this into a mergeable state in #167 but I ran out of time.

@benjie benjie changed the base branch from master to main June 24, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singingwolfboy @benjie