New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We aren't using catch functionality #37

Open

moizhusnain opened this issue Aug 30, 2022 · 0 comments

Member

moizhusnain commented Aug 30, 2022

js-sdk/src/handlers/duplex.handler.js

Line 228 in 61db45f

this.tasks.emit(data.header.id, data.payload);

Our server also provides res.error functionality, ideally we should reject promise when server marks the response as error, but we aren't using this functionality. (https://github.com/grandeurdev/backend/blob/bf3429441b84326b80b34e4977a653fde2e602a8/routes/duplex/projects.js#L28)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment