Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user information to settings pages #532

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

letsjustfixit
Copy link
Contributor

closes #376
Extended SystemInfo
Extended Logout

  • The Username and permissions level should show beside the "LOGOUT" button in User Settings
  • The tree ID, username and permissions level should be included in the System Information that can be "Copy to clipboard"
  • tree ID & username should not be in the copied data as they can represent personally identifiable information.

@DavidMStraub
Copy link
Member

Nice, thanks!

For the sysinfo tab, the UI is misleading though - the gray clipboard icon with the gray rounded box clearly communicates to the user that they are copying this box's content. Also, the user name and role are not part of the information about the system. So my proposal is:

  • remove user name and role from the sys info tab
  • Move the tree ID below the gray rounded box

Concerning the user name and role, in my opinion admin [Administrator] is not clear enough. Let's be explicit about what they represent (user name and role).

@DavidMStraub DavidMStraub changed the title ℹAdditional user attributes on Add user information to settings pages Nov 23, 2024
@letsjustfixit
Copy link
Contributor Author

How about this?
Tree below
User-role

…s above logout plus the above and tree ID to System Information
@letsjustfixit
Copy link
Contributor Author

@DavidMStraub ready ^

@DavidMStraub DavidMStraub merged commit 06f7439 into gramps-project:main Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tree ID, username and permissions level to System Information
2 participants