-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Family tree option to see every person #313
Comments
This can be pretty useful when you try to get some sort overview. However, this adds significant more complexity, which should be taken into account:
|
Who can I turn to or who can I commission to do this and of course pay for it to be realized? |
Definitely. The family tree export option is actually what I wanted. I didn't know that this feature existed. Maybe you can integrate that in the graph view as well? |
Any update on this one? How much would it take to change so you can see every person in family tree? |
If no one is assigned to the issue, you can assume that it's not actively being worked on. Just one week ago, we had a new release with a new hourglass chart. Beyond that, it's significantly more work. |
I propose to break this issue up into 4 parts:
|
step 1 is done. d3-graphviz would work, however, the underlying hpcc-wasm is sufficient and complexity is reduced by using it directly. Thus, we should decide the structure of the data visualized. There are two main options:
Option 1 is straight forward and very generic, but leads to a factor of 2 connectors compared to option 2. A larger example of Option 2: Any Opinions? |
Great! I don't have a strong opinion about option 1 vs 2. Perhaps option 2 is a bit cleaner, but either would be fine I think. Regarding step 3: I guess the backend should already have the required functionality using person filters, and then adding a preprocessing step in Javascript, similarly to how we use |
Oh I get it, we need a graphviz file, right? |
As a very happy user of grampsweb and also of the H-chart plugin in gramps desktop (which also displays a more complete view of the family tree) I thought I'd share my opinion on the matter. Love the project and I'm very curious how this view will turn out. |
Yep. The flow would be: The last step needs to be done in the frontend (javascript), for the others we are free. If we do the first three steps in the backend, every change in the filter would trigger a backend roundtrip. However, dealing significant with data (creating nodes) in the frontend, might be bad architecture. Not sure, what would be best. |
After looking into the existing code of the tree charts, I propose to do all steps (filter persons using the existing backend service, create coupld nodes, create dot string and finally render it) in the frontend. I meanwhile got what you ment @DavidMStraub . Option 2 seems to be agreed on. For the filter, the distance to the root person shoud be ok:
additionally, uniqueness of persons has to be checked, in cases where you have circular relationships. @DavidMStraub if you could have a look at this as suggested, this would be great. I can do the code for creating the nodes, dot string and render it. Concerning #347 : I have no opinion on that, offering two ways to users seems not to be a problem. |
Sounds good! I looked into the filter and, to my surprise, found that this is not possible in Gramps core, but there is an addon doing just that written by @Mattkmmr 🎉 I will install the addon into the API default docker image as we already do for the PostgreSQL addon. |
@geostag in this branch https://github.com/gramps-project/gramps-web/tree/relationship_graph I added a placeholder |
thank you, I will do the further work on this branch. |
Just want to give an update on this. After struggling with a bunch of different issues, I'd like to show the current state of this enhancement:
|
Nice! Concerning the font issue: if we grab the SVG from the container and then pass it to d3, why can't we style everything with CSS using d3 in this final step, independently of which font graphviz used? (I never tried this, so might be a silly question.) |
Just wanted to know if there are any thoughts on serving the fonts directly. And yes, indeed, the way outlined on doing the font-sizing in d3 is the alternative. I will go for that. |
#401 Comments welcome, still some data interpretation issues |
Looks great! Perhaps some options for the style of the lines would be nice (orthogonal, smoothed, straight). It could also be interesting to show marriage status and date for each set of parents. These are all small things, because this looks really great already. |
edge style is generated directly by the underlying graphviz. While graphviz has more options (splines, ortho), they look even worse in this context. I would prefer to start with the actual setup using "polyline". Will try to add marriage status and date without using too much space - the graph already tends to be generally very wide. |
still open and might be done in future:
|
closed with #401 |
It would be nice if there is an option that shows every person that is related to the home person in the tree view. So if there is any connection possible, that person is shown. This would be a nice feature, because it is currently not possible to see every person in the family tree using the ancestor or descendant tree.
The text was updated successfully, but these errors were encountered: