Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13867 - remove resolution strategy assignment and use default #13868

Merged

Conversation

jdaugherty
Copy link
Contributor

Per discussion in today's stewards meeting, this removes the resolution strategy assignment.

Copy link
Contributor

@codeconsole codeconsole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

welll... if you are going to delete line 549, how about you fix 546 and 547 to } else {
😉

@matrei
Copy link
Contributor

matrei commented Nov 22, 2024

@jdaugherty Can you merge 7.0.x into this branch? I'm seeing ClassNotFoundException: org.grails.spring.config.http.GrailsFilters in grails-functional-tests. GrailsFilters has recently been moved to org.grails.web.config.http.GrailsFilters.

@jdaugherty jdaugherty force-pushed the feature/7.0.0/13867-delegate-resolution branch from 47bc24d to c508c5b Compare November 22, 2024 22:27
@jdaugherty jdaugherty force-pushed the feature/7.0.0/13867-delegate-resolution branch from c508c5b to 0501666 Compare November 22, 2024 22:28
@jdaugherty
Copy link
Contributor Author

@matrei this should be updated

@matrei
Copy link
Contributor

matrei commented Nov 22, 2024

Thanks!

@jdaugherty jdaugherty merged commit 80588a9 into grails:7.0.x Nov 22, 2024
19 checks passed
@jdaugherty jdaugherty deleted the feature/7.0.0/13867-delegate-resolution branch November 22, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants