[tempo-vulture] feat: add option to deploy podmonitor and add option to remove svc #3221
+69
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyriosGN0
force-pushed
the
feat-remove-svc-add-podmonitor
branch
from
4571d9c
to
a0b0c1e
Compare
|
hey @Whyeasy @dgzlopesm, another ping... |
zanhsieh
approved these changes
Aug 9, 2024
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
KyriosGN0
force-pushed
the
feat-remove-svc-add-podmonitor
branch
from
893ddfe
to
49749fd
Compare
Signed-off-by: AvivGuiser <[email protected]>
|
@zanhsieh i rebased according to new chart, is it possible to get a review ? (also from codeowners?) |
|
@zalegrala @Sheikh-Abubaker |
|
Hi thanks for the PR. Can you add a little context about why this change is necessary? |
|
hey @zalegrala in general in my org we prefer the option to disable services and use pod-monitors instead of service monitor |
|
Hi, I'm a bit slow. Is there a reason we need the service for vulture at all? |
|
@zalegrala as far as i understand no, its entirely a "client" application, only reason for service is for service monitor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added option to opt out of using a service (still enabled by default) and add podMonitor which is disabled by default