Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation source code can be tested #43

Closed
bmuschko opened this issue Nov 29, 2018 · 5 comments
Closed

Documentation source code can be tested #43

bmuschko opened this issue Nov 29, 2018 · 5 comments
Assignees

Comments

@bmuschko
Copy link
Contributor

  • Create test cases
  • Tests pass on CI
  • Potentially use Exemplar
@bmuschko bmuschko self-assigned this Nov 29, 2018
@bmuschko
Copy link
Contributor Author

Implementation:

@big-guy
Copy link
Member

big-guy commented Dec 13, 2018

For the samples that need additional dependencies, do you have another issue for tracking that?

@bmuschko
Copy link
Contributor Author

@big-guy Can you elaborate? I don't quite understand what you mean.

@bmuschko
Copy link
Contributor Author

@big-guy There's more to that test code in these samples. I think they were built with an older version of Play and are not completely incompatible: changed APIs, different imports, missing dependencies. I spent about an hour on it but couldn't make it work. I think somebody with proper knowledge of the Play API would get the solution much faster. I created #74 with my findings.

@big-guy
Copy link
Member

big-guy commented Dec 19, 2018

This good enough for now

@big-guy big-guy closed this as completed Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants