Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The performance comparison between flash attn and ring flash attn #14

Open
GeneZC opened this issue Mar 22, 2024 · 0 comments
Open

The performance comparison between flash attn and ring flash attn #14

GeneZC opened this issue Mar 22, 2024 · 0 comments

Comments

@GeneZC
Copy link

GeneZC commented Mar 22, 2024

https://github.com/cuda-mode/ring-attention/blob/65f904c812eae6e0c75185c49c8eab5717c25343/ring-llama/modeling_llama.py#L669

While it is acceptable that ring flash attn could lag behind flash attn in terms of speed, I am wondering whether the ring flash attn could outperform the flash attn in terms of memory use?

And it has been witnessed that in both aspects, ring flash attn can underperform flash attn (zhuzilin/ring-flash-attention#23), which is not that reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant