Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slanting fixes for diagonals and curves (e.g. D, V) #214

Open
tphinney opened this issue Nov 19, 2019 · 18 comments
Open

Slanting fixes for diagonals and curves (e.g. D, V) #214

tphinney opened this issue Nov 19, 2019 · 18 comments
Assignees
@tphinney
Labels
enhancement New feature or request

Comments

@tphinney
Copy link
Collaborator

tphinney commented Nov 19, 2019 •
edited
Loading

In the slanted masters, when things are slanted automatically, it has bad effects on diagonals and curves.

A short tight curve like those seen in the /O or /S is not bad, but a big sweeping curve on the /D is problematic.

With diagonals, a left slope gets thicker when slanted right, and a right slope gets thinner. For example with the /V the left side gets thicker and the right side gets thinner. This needs to be compensated for. For example, in the V, after slanting, the inner triangle of points can be moved to the left, making the left stroke thinner and the right thicker.

The amounts of compensation needed depends on both the thickness of the strokes, and the original angles. A thicker stroke will be more affected, and if the shift is centered on a 45° angle, that maximizes the effect. So for example, the condensed V designs need less adjustment, post-slant.

Done: /A /D /N /M /Q /Q.alt /R /K /V /W /X /Y /Z /k /v /w /x /y /z

Brandon done:
/d.smcp /two /two.dnom /four /four.dnom /six /six.dnom /seven /seven.dnom /nine /nine.dnom /ampersand /ampersand.sc /question /question.sc /questiondown /questiondown.sc
/asterisk /uni2116 (numero) /Oslash /oslash.sc /oslash /Lslash /lslash /slash /backslash /fraction /uni2215 /AE /acutecomb /acutecomb.case /gravecomb /gravecomb.case /tildecomb /tildecomb.case /asciitilde /uni1E9E (cap eszett) /uni1E9E.c2sc /asciicircum /uni0302 /uni0302.case /uni0327 (cedilla) /uni0327.case /uni0306 (breve) /uni0306.case /uni0328 (ogonek) /uni0328.case /uni0309 (hook) /uni0309.case /uni031B (horn) /uni031B.case /trademark /less /greater /greaterequal /lessequal /multiply /uni27E8 /uni27E9 /m.sc /n.sc /q.sc /r.sc /ae.sc

Backlog (TO DO):

  • /uni20AD (kip currency) /uni20B9 (rupee) /uni20BA (Turkish Lira)
  • /m.sc /n.sc /w.sc /x.sc /y.sc /z.sc (still need to do :CtrEtc)
  • various Cyrillic unique shapes (? Not sure, maybe Vassil already did these
@tphinney tphinney added the enhancement New feature or request label Nov 19, 2019
servantb added a commit that referenced this issue Nov 21, 2019
@servantb
Update ScienceGothic-4a-36m.vfj
bede915 
Edited curves of /D and adjusted anchors in the :SEtc masters (issue #214).
@tphinney
Copy link
Collaborator Author

Did /k /v /w /x /y /z

@tphinney
Copy link
Collaborator Author

Brandon did /D

tphinney added a commit that referenced this issue Nov 21, 2019
@tphinney
Fixes to diagonals and italics in master fonts
c3b9c17 
#213 adjustments to flare in /k /w v/ /x /y etc., esp in :CtrEtc masters
#214 :EtcS (slant) master fixes for /k /v /w /x /y /z

/K :BlkExt +10 units to arm and leg
/R :BlkExt +30 units to leg
@kateliev kateliev self-assigned this Nov 21, 2019
@kateliev
Copy link
Member

Cyrillic Diagonals fix: /uni0414 /uni041B /uni0409 /uni042F /uni0434 /uni043B /uni0459 /uni0474 /uni0475

kateliev added a commit that referenced this issue Nov 21, 2019
@kateliev
Slant: Anchors + Diagonals
0cd6e25 
#212 Anchors fix: /O /W /Z
#214 Diagonals fix: /uni0414 /uni041B /uni0409 /uni042F /uni0434 /uni043B /uni0459 /uni0474 /uni0475
tphinney added a commit that referenced this issue Nov 22, 2019
@tphinney
Updated fonts masters (VFC, VFJ)
558056d 
Fixed double-slant in italic:
/uni2033 (double prime)

Fixed spacing all masters:
/u /Z /z /z.smcp

Edited to make lighter: /Z /z /z.smcp (medium weights, except condensed)

#218 (started fix)
Increased width/counter: /c.smcp /s.smcp (condensed, condensed slant)

#214 (started fix)
:EtcS (slant) master fixes for some glyphs:
/a.smcp /k.smcp /v.smcp /w.smcp /x.smcp /y.smcp /z.smcp
@tphinney
Copy link
Collaborator Author

Did /N and /M today after I realized they were missing from the list.

Started yesterday on /a.smcp /k.smcp /v.smcp /w.smcp /x.smcp /y.smcp /z.smcp, still in progress.

servantb added a commit that referenced this issue Nov 23, 2019
@servantb
Issue #214 Checked and edited /d.smcp /two /two.dnom in the :SEtc mas…
7d5a822 
…ters. Fixed anchors in /d.smcp.
tphinney added a commit that referenced this issue Nov 25, 2019
@tphinney
Updated font source files—MANY changes
dbf4d7b 
worked on small caps in italics, finished the non-contrast versions for: /a.sc /k.sc /v.sc /w.sc /x.sc /y.sc /z.sc

Renamed glyph germandbls.sc > germandbls.smcp (the cap form of germandbls is uni1E9E and has its own .c2sc version)

#214 Fixed /N /M italic (slant) diagonals

#216 Redefined default instance to be Regular instead of Medium (and made corresponding  changes to the weight mapping so the Regular is heavier, close to the old Medium). This will stop us from getting both "Regular" and "Regular1" in font menus.

#217 Swapped alternate /Euro into regular slot (deleted former default version)

Added /uni051A.alt (designspace alt for Cyrillic Qa)

some of the new accented a-italic variant glyphs were misnamed, fixed that so their names match the upright versions (mostly going to uniXXXX names)

a couple of the same glyphs had a dot below that was misplaced, too low. This is fixed and the recipe for these glyphs was corrected

deleted several former components, no longer needed in assembly of currency glyphs (crossbars and the lira/sterling body)
kateliev added a commit that referenced this issue Nov 25, 2019
@kateliev
Issues #209, #59, #214
b787e81 
#209 Fixed overslant + SBs + recipes (where needed): /quoteleft /quoteright /quoteleft.sc /quoteright.sc /uni02BC /guilsinglleft /guilsinglright /guillemotleft /guillemotright /guilsinglleft.case /guilsinglright.case /guillemotleft.case /guillemotright.case /uni0335 /quotesingle.sc /underscore /uni0331.case /uni0304.case /uni0331.case  /uni0304.case /Eth (rebuild)

#59 SMCP Orphans: /eng.sc

#214 Diagonals fix-up: /uni0416
#214 Curves regeneration /uni0417 /three /three.dnom /uni0437
kateliev added a commit that referenced this issue Nov 27, 2019
@kateliev
#172 Remove Overlap, #214 Slant Fixes
ec18497 
#172 Remove Overlap + Contour adjustments + Metrics fix + "Copy to light masters": /uni018F /Eth /eth /Hbar /hbar /uni2190 /uni2191 /germandbls /Lslash /lslash /tbar /dcroat /eth.sc /lslash.sc /tbar.sc /sterling.alt /Eng /peseta /uni20AE /uni20BD /uni20BC /uni20BA /uni20B1 /uni20AB /franc /section /registered

#214 Fix diagonals: /uni043B.sc /uni0434.sc /uni0459.sc /uni0475.sc /uni04AF /uni04B1 /uni04B0 /uni04B1.sc /uni046B.sc /uni046B /uni046A

Metrix fix:  /uni1E9E.c2sc /germandbls.smcp
servantb added a commit that referenced this issue Nov 27, 2019
@servantb
Issue #214 Checked and edited /four /four.dnom /six /six.dnom /seven …
3cb29fc 
…/seven.dnom /nine /nine.dnom /ampersand /ampersand.sc /question /question.sc /asterisk and /numbersign in the :SEtc masters.
servantb added a commit that referenced this issue Dec 5, 2019
@servantb
Checked and edited /uni2116, /Oslash, /oslash.sc, and /oslash (issue #…
c9e0ad6 
…214)
@servantb
Copy link
Collaborator

servantb commented Dec 5, 2019

Checked and edited /uni2116, /Oslash, /oslash.sc, and /oslash

@servantb
Copy link
Collaborator

On Dec 9, adjusted widths of diagonals in slanted masters for /Lslash /lslash /slash /fraction
Made initial adjustments to /backslash, but it has... issues.

servantb added a commit that referenced this issue Dec 11, 2019
@servantb
Issue #214 Adjusted widths of diagonals in slanted masters for /backs…
17adcb0 
…lash /lslash.sc /AE /acutecomb /acutecomb.case
@servantb
Copy link
Collaborator

Issue #214
Adjusted widths of diagonals in slanted masters for /backslash /lslash.sc /AE /acutecomb /acutecomb.case

servantb added a commit that referenced this issue Dec 17, 2019
@servantb
Issue #214 Adjusted widths of diagonals in slanted masters for /grave…
16965a6 
…comb /gravecomb.case
@servantb
Copy link
Collaborator

Adjusted widths of diagonals in slanted masters for /gravecomb /gravecomb.case

servantb added a commit that referenced this issue Jan 16, 2020
@servantb
File cleanup and multiple slant fixes
8e2cb46 
Deleted ScienceGothic-4a-36m.vfj from VFC folder and ScienceGothic-4a-36m.vfc from VFJ folder

Issue #214
Adjusted widths of diagonals in slanted masters for /tildecomb /tildecomb.case /asciitilde /uni1E9E (cap eszett) and /uni1E9E.c2sc

Slightly tweaked the :LtReg ampersand to help facilitate better transition to the :LtCnd.
@servantb
Copy link
Collaborator

Adjusted widths of diagonals in slanted masters for /tildecomb /tildecomb.case /asciitilde /uni1E9E (cap eszett) and /uni1E9E.c2sc

servantb added a commit that referenced this issue Jan 16, 2020
@servantb
Issue #214: Adjusted widths of diagonals in slanted masters for /asci…
d5d1cc4 
…icircum /uni0302 /uni0302.case
@servantb
Copy link
Collaborator

Adjusted widths of diagonals in slanted masters for /asciicircum /uni0302 /uni0302.case

servantb added a commit that referenced this issue Jan 20, 2020
@servantb
Edited /uni0327 (cedilla) and /uni0327.case
86dfb90 
Issue #214
Adjusted widths of diagonals in slanted masters for /uni0327 (cedilla) /uni0327.case

Massaged curves in /uni0327 (cedilla) /uni0327.case :LtEtc and :BlkExpEtc masters; reduced "spur" size in :CtrEtc masters.
@servantb
Copy link
Collaborator

Adjusted widths of diagonals in slanted masters for /uni0327 (cedilla) /uni0327.case

servantb added a commit that referenced this issue Jan 21, 2020
@servantb
Issue #214 Adjusted widths of curves in slanted masters for /uni0306 …
7ed646f 
…(breve) /uni0306.case /uni0328 (ogonek) /uni0328.case /uni0309 (hook) /uni0309.case /uni031B (horn) /uni031B.case /trademark
@servantb
Copy link
Collaborator

Adjusted widths of curves in slanted masters for /uni0306 (breve) /uni0306.case /uni0328 (ogonek) /uni0328.case /uni0309 (hook) /uni0309.case /uni031B (horn) /uni031B.case /trademark

servantb added a commit that referenced this issue Feb 1, 2020
@servantb
Adjusted widths of diagonals in slanted masters for /less /greater /g…
13393e3 
…reaterequal /lessequal /multiply /uni27E8 /uni27E9 /m.sc /n.sc /q.sc /r.sc /ae.sc (issue #214)
@servantb
Copy link
Collaborator

servantb commented Feb 1, 2020

Adjusted widths of diagonals in slanted masters for /less /greater /greaterequal /lessequal /multiply /uni27E8 /uni27E9 /m.sc /n.sc /q.sc /r.sc /ae.sc

@kateliev
Copy link
Member

@tphinney do we have current status for this issue - it seems rather old and has a lot of pushed fixes. Is there something we could do more?

@tphinney
Copy link
Collaborator Author

tphinney commented Apr 15, 2022 •
edited
Loading

I have reviewed the thread; the initial message at the top, at the bottom of it, has been repeatedly edited to track fixes. I am continuing to edit it and keep it up to date. :)

tphinney added a commit that referenced this issue Apr 16, 2022
@tphinney
(VFC only) improve slanted diagonals in uni049D.sc #214
aa9f3cc 
uni049D.sc is just one of the many glyphs needing work for #214
Was working on it for another issue, so continued on to this fix as well.
tphinney added a commit that referenced this issue Apr 19, 2022
@tphinney
fix a.sc in source (part of #214)
7095c61
tphinney added a commit that referenced this issue Apr 19, 2022
@tphinney
fix k.sc (part of #214) in VFC source
4b90cef
tphinney added a commit that referenced this issue Apr 19, 2022
@tphinney
fix v.sc (part of #214) in VFC source
8b5d31e
tphinney added a commit that referenced this issue Apr 19, 2022
@tphinney
fix w.sc (part of #214) in VFC source
d0c6264
@tphinney tphinney moved this to In progress in Science Gothic VF Jun 10, 2024
@kateliev
Copy link
Member

@tphinney is this still relevant?

@servantb
Copy link
Collaborator

servantb commented Jul 26, 2024 via email

@tphinney
Copy link
Collaborator Author

Certainly at least a LOT of it got done. I wish I was sure whether ALL of it got done.

I would like to review when I am back home with big monitors, in a week or two. Would be especially looking at more obscure characters that might still have the problem. I will leave this assigned just to me for the moment.

@tphinney tphinney moved this from In progress to To Test in Science Gothic VF Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tphinney tphinney

Labels
enhancement New feature or request
Projects
Science Gothic VF
Status: To Test
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tphinney @kateliev @servantb