You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fontc is not computing the head table's checkSumAdjustment field, so it defaults to 0x0.
And neither is write_fonts. Not sure whose responsibility it should be, whether the client (fontc) or write_fonts itself.
Probably the latter?
Anyway, ttx_diff.py currently erases the field altogether so we may get "fonts are identical" but actually the checkSumAdjustment is plain wrong.
Ok, you may argue it's garbage anyway and nobody should trust that, but if we want to be nice we should just compute that correctly, e.g. the same way fontmake/fonttools would, with all the "BiboAfba" and funny things like that:
Maybe open a new one there and reference it? - it's still true that fontc has a bug so I think we shoudl keep this one even if the fix ends up just being an update to our fontations version.
fontc is not computing the head table's
checkSumAdjustment
field, so it defaults to 0x0.And neither is write_fonts. Not sure whose responsibility it should be, whether the client (fontc) or write_fonts itself.
Probably the latter?
Anyway, ttx_diff.py currently erases the field altogether so we may get "fonts are identical" but actually the checkSumAdjustment is plain wrong.
Ok, you may argue it's garbage anyway and nobody should trust that, but if we want to be nice we should just compute that correctly, e.g. the same way fontmake/fonttools would, with all the "BiboAfba" and funny things like that:
https://github.com/fonttools/fonttools/blob/c2119229cfb02cdb7c5a63374ef29d3d514259e8/Lib/fontTools/ttLib/sfnt.py#L375-L406
The text was updated successfully, but these errors were encountered: